Skip to content

[PLT-0] Prep Release v.3.75.0 #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Conversation

adrian-chang
Copy link
Contributor

Description

Release v.3.75.0

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

@adrian-chang adrian-chang requested a review from a team as a code owner July 10, 2024 22:41
Copy link
Contributor

@vbrodsky vbrodsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are re CHANGELOG messages
I've been following the feedback previously received from MLSE (John?), which involved reviewing and polishing merge commit messages to ensure a professional look in the CHANGELOG. Additionally, I've omitted comments related to internal commits focused solely on test fixes and refactoring.
However, I'm unsure if this approach is still the preferred method. Has there been a shift towards including all commits in the CHANGELOG, regardless of their nature?
Even we stick with this approach, I think we need to fix text for a couple of those commits messages

vbrodsky
vbrodsky previously approved these changes Jul 10, 2024
@adrian-chang adrian-chang merged commit 3bcc4f1 into develop Jul 11, 2024
10 of 20 checks passed
@adrian-chang adrian-chang deleted the achang/plt-0-prep-release branch July 11, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants