-
Notifications
You must be signed in to change notification settings - Fork 68
[PLT-1271] Improve annotation import test library #1714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lbox-python into gu/improve_annotation_test
@@ -1,45 +0,0 @@ | |||
import uuid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted this file since we are testing already for conversation entity import with test_generic_data_types
@@ -1,12 +1,8 @@ | |||
import datetime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heavily reduced the test on this file and focused on unit testing serializing data type labels to NDJSON format. Generic data types tests the importing of NDJSON. I feel like it was a waste to double test this considering how long importing annotations takes when you consider set up and such
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also data types is marked as depercated
…lbox-python into gu/improve_annotation_test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this is broken up into more smaller changes to derisk a large change (even though these are tests, better to change them in smaller units of work). Note to consider next time to prevent rework right now.
Description
Type of change
Please delete options that are not relevant.
All Submissions