Skip to content

[PLT-1271] Improve annotation import test library #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jul 12, 2024

Conversation

Gabefire
Copy link
Collaborator

@Gabefire Gabefire commented Jul 5, 2024

Description

  • Made huge QOL and improved to annotation import library
  • Added connect_ontology in place of setup method
  • Documented different methods

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

@Gabefire Gabefire requested a review from a team as a code owner July 5, 2024 20:40
@Gabefire Gabefire marked this pull request as draft July 5, 2024 20:44
@@ -1,45 +0,0 @@
import uuid
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted this file since we are testing already for conversation entity import with test_generic_data_types

@@ -1,12 +1,8 @@
import datetime
Copy link
Collaborator Author

@Gabefire Gabefire Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heavily reduced the test on this file and focused on unit testing serializing data type labels to NDJSON format. Generic data types tests the importing of NDJSON. I feel like it was a waste to double test this considering how long importing annotations takes when you consider set up and such

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also data types is marked as depercated

@Gabefire Gabefire marked this pull request as ready for review July 9, 2024 14:24
@Gabefire Gabefire changed the title Improve annotation import library to expand [PLT-1271] Improve annotation import library to expand Jul 9, 2024
@Gabefire Gabefire changed the title [PLT-1271] Improve annotation import library to expand [PLT-1271] Improve annotation import library Jul 9, 2024
@Gabefire Gabefire changed the title [PLT-1271] Improve annotation import library [PLT-1271] Improve annotation import test library Jul 9, 2024
Copy link
Contributor

@adrian-chang adrian-chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this is broken up into more smaller changes to derisk a large change (even though these are tests, better to change them in smaller units of work). Note to consider next time to prevent rework right now.

@Gabefire Gabefire merged commit d4b545d into develop Jul 12, 2024
22 checks passed
@Gabefire Gabefire deleted the gu/improve_annotation_test branch July 12, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants