Skip to content

[PLT-1205] address feedback from part 1 #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2024
Merged

[PLT-1205] address feedback from part 1 #1708

merged 1 commit into from
Jul 2, 2024

Conversation

adrian-chang
Copy link
Contributor

Description

Update error messages to be more descriptive

@adrian-chang adrian-chang requested a review from a team as a code owner July 2, 2024 00:31
vbrodsky
vbrodsky approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@vbrodsky vbrodsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this message better? I.e. it is not clear from it what is the cause. Is there no better way to identify the cause?

@adrian-chang
Copy link
Contributor Author

Check line 292 in client, we'd need to change it everywhere for resource not found

@adrian-chang adrian-chang merged commit ec3b7ec into develop Jul 2, 2024
22 checks passed
@adrian-chang adrian-chang deleted the achang/plt-1205-ug-ux-improvements-2 branch July 2, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrodsky vbrodsky vbrodsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrian-chang @vbrodsky