Skip to content

[PLT-1231] Add missing media types #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

adrian-chang
Copy link
Contributor

Description

Add missing media types (ontology types)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@adrian-chang adrian-chang requested a review from a team as a code owner June 28, 2024 22:39
@@ -20,6 +20,8 @@ class MediaType(Enum):
Unknown = "UNKNOWN"
Unsupported = "UNSUPPORTED"
Video = "VIDEO"
Point_Cloud = "POINT_CLOUD"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is point_cloud :)?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a point cloud is a 3d scene with only points, no edges.

vbrodsky
vbrodsky previously approved these changes Jul 1, 2024
@vbrodsky vbrodsky force-pushed the achang/plt-1231-missing-media-types branch from 738fb0e to 2ba1dee Compare July 1, 2024 15:56
@adrian-chang adrian-chang force-pushed the achang/plt-1231-missing-media-types branch from 2ba1dee to 534a253 Compare July 1, 2024 18:10
@adrian-chang adrian-chang merged commit 7ddeef7 into develop Jul 1, 2024
22 checks passed
@adrian-chang adrian-chang deleted the achang/plt-1231-missing-media-types branch July 1, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants