[PLT-0] Fix Integration Tests #1699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-chang
force-pushed
the
achang/plt-0-int-tests-
branch
from
20fa9a1 to
19df06a
Compare
adrian-chang
force-pushed
the
achang/plt-0-int-tests-
branch
3 times, most recently
from
1d529c4 to
91be53a
Compare
vbrodsky
reviewed
Jun 28, 2024
| @@ -25,7 +25,7 @@ | |||
|
|
|||
| """ | |||
|
|
|||
|
|
|||
| @pytest.mark.order(1) | |||
There was a problem hiding this comment.
This test is very slow, this guarantees it runs first (given all tests that you may be running) to prioritize it to optimize testing time
adrian-chang
force-pushed
the
achang/plt-0-int-tests-
branch
from
74b2d2a to
6fcae4d
Compare
adrian-chang
force-pushed
the
achang/plt-0-int-tests-
branch
from
515f2ab to
839035a
Compare
adrian-chang
force-pushed
the
achang/plt-0-int-tests-
branch
from
839035a to
7815ca0
Compare
adrian-chang
commented
Jun 28, 2024
| @@ -259,7 +198,7 @@ def validate_iso_format(date_string: str): | |||
| assert parsed_t.minute is not None | |||
| assert parsed_t.second is not None | |||
|
|
|||
|
|
|||
| @pytest.mark.order(1) | |||
There was a problem hiding this comment.
These are to note to run first because they are slower
vbrodsky
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Please delete options that are not relevant.
Changes to Core Features