Skip to content

[MODEL-1474] Quality modes as list #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 24, 2024
Merged

[MODEL-1474] Quality modes as list #1683

merged 22 commits into from
Jul 24, 2024

Conversation

kozikkamil
Copy link
Contributor

@kozikkamil kozikkamil commented Jun 19, 2024

Description

Allow creation of projects as both benchmark and consensus. Can only be rolled out after B&C GA.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@kozikkamil kozikkamil requested a review from a team as a code owner June 19, 2024 13:46
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@vbrodsky vbrodsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think making queue_mode from QualityModel to List[...] makes it incompatible for sdk users. You need to be able to take in either one or the whole list

vbrodsky
vbrodsky previously approved these changes Jul 5, 2024
@kozikkamil kozikkamil requested a review from vbrodsky July 10, 2024 13:15
vbrodsky
vbrodsky previously approved these changes Jul 11, 2024
Copy link
Contributor

@vbrodsky vbrodsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two comments for what I see as improvements, let me know what you think
Also are you planning to update sdk integration tests now or in the future

@kozikkamil kozikkamil requested a review from vbrodsky July 24, 2024 10:21
vbrodsky
vbrodsky previously approved these changes Jul 24, 2024
@vbrodsky vbrodsky merged commit 5bf3de0 into develop Jul 24, 2024
4 checks passed
@vbrodsky vbrodsky deleted the kozikkam/MODEL-1474 branch July 24, 2024 17:17
vbrodsky pushed a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants