-
Notifications
You must be signed in to change notification settings - Fork 68
[MODEL-1474] Quality modes as list #1683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think making queue_mode from QualityModel to List[...] makes it incompatible for sdk users. You need to be able to take in either one or the whole list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two comments for what I see as improvements, let me know what you think
Also are you planning to update sdk integration tests now or in the future
This reverts commit 5bf3de0.
Description
Allow creation of projects as both benchmark and consensus. Can only be rolled out after B&C GA.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
All Submissions
New Feature Submissions
Changes to Core Features