-
Notifications
You must be signed in to change notification settings - Fork 68
GH Issue: Set Numpy < 2.0.0 as a requirement since it breaks our package #1681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to rebuild requirements.lock
eg rye sync
or rye sync --update-all -f
if you want to try and update all deps
9e88215
to
8142414
Compare
@adrian-chang So I did a ton of research once you mentioned this. Here is a quick loom TLDR: essentially the optional dependencies don't get included on the requirements.lock. When install "labelbox[data]" it Edit: disregard pillow change this is a Colab itself issue thus it is not a concern for us and should support the highest bug fix release
|
Description
From the linked issue, if someone has numpy >2.0, it breaks our package. This is due to Numpy >2,0 supporting Python 3.9 and above and 2.0 being a major release (first major release since 2006), i.e., changing a lot of how Numpy functions. Specified version 2.0 or below with rye to avoid confusion. Also cleaned up whitespace in pyproject file. See linked issue for more information
Numpy just released this version on the 6/13. Provided a comment to pyproject for information we can remove this once we removed support for 3.8 in Oct due to EOL of 3.8
Type of change
Please delete options that are not relevant.
All Submissions