Skip to content

Swapped/marked remaining V1 methods in tests #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

Gabefire
Copy link
Collaborator

@Gabefire Gabefire commented Jun 16, 2024

Description

  • A lot of our tests use V1 methods. I went ahead and marked (v1 export tests directly) and swapped other parts of test with either export V2 or different methods
  • Also marked a few fixtures to consider swapping later (setup -> setup_editor) since they might get removed soon and how it is set up causes issues with export.
  • Tests work locally but send_to_annotate wont work in staging right now due to limited tasks hopefully will be fixed soon

The direct V1 method tests are located here:
tests/integration/test_batch.py
tests/data/annotation_import/test_data_types.py
tests/data/annotation_import/test_model_run.py
tests/data/export/legacy/test_legacy_export.py (file just tests export v1 methods likely delete after migration)
tests/data/export/legacy/test_export_project.py (has a V1 test)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?
  • Tests run (besides send to annotate for reasons above)

@Gabefire Gabefire marked this pull request as ready for review June 16, 2024 01:04
@Gabefire Gabefire requested a review from a team as a code owner June 16, 2024 01:04
@Gabefire Gabefire merged commit 10840ce into develop Jun 26, 2024
18 of 22 checks passed
@Gabefire Gabefire deleted the gu/test_migration_annotation_imports branch June 26, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants