Skip to content

Removed Catelog export experiment flag #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2024
Merged

Removed Catelog export experiment flag #1668

merged 2 commits into from
Jun 11, 2024

Conversation

Gabefire
Copy link
Collaborator

@Gabefire Gabefire commented Jun 11, 2024 •
edited
Loading

Description

  • Removed experiment flag on Catalog export. This matches all other export methods. I think we just missed this flag because export_v2 for catalog does not have this present and it uses the same backend

Type of change

  • Bug fix

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

@Gabefire Gabefire requested a review from a team as a code owner June 11, 2024 14:16
@Gabefire
Copy link
Collaborator Author

Removed doc string info on export Catalog with deprecated methods this matches other export doc strings

@Gabefire Gabefire merged commit 88c846b into develop Jun 11, 2024
15 of 22 checks passed
@Gabefire Gabefire deleted the gu/removed_export_experiment_flag branch June 11, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian-chang adrian-chang adrian-chang approved these changes

@sfendell-labelbox sfendell-labelbox sfendell-labelbox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gabefire @adrian-chang @sfendell-labelbox