[PLT-1107] Add validation for empty row_data for Dataset create_data_rows #1667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrodsky
force-pushed
the
VB/fix_row_data_validation
branch
from
22b9a3a to
ee84e44
Compare
vbrodsky
force-pushed
the
VB/fix_row_data_validation
branch
from
ee84e44 to
bf3b7c8
Compare
sfendell-labelbox
approved these changes
Jun 11, 2024
| if len(string_items) > 0: | ||
| dict_string_items = self._build_from_local_paths(string_items) | ||
| specs = DataRowUpsertItem.build(self.uid, | ||
| specs = DataRowCreateItem.build(self.uid, |
There was a problem hiding this comment.
I thought the point was to maximize use of upsert ... was this on purpose or just for this use case?
There was a problem hiding this comment.
Yes we are using upsert, and this change just captures difference in data formatting and validation between create and upsert on the sdk side due to a number of edge cases for create
|
Lots of flaky tests, passing locally. Merging PR, will look to address the tests separately |
Merged
14 tasks
vbrodsky
pushed a commit
that referenced
this pull request
Jun 13, 2024
…t create_data_rows (#1667)"
14 tasks
vbrodsky
pushed a commit
that referenced
this pull request
Jun 13, 2024
…t create_data_rows (#1667)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During my implementation / refactor of Dataset
create_data_rows, I somehow dropped validation of empty row_data. This PR restores validation of row_data and throws and error if it is None or an empty stringFixes the issue discussed here https://labelbox.slack.com/archives/CPVQE6T2T/p1718010997829539
Type of change
Please delete options that are not relevant.
All Submissions
Changes to Core Features