Skip to content

[PLT-901] Vb/fix some tests plt 901 #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2024
Merged

[PLT-901] Vb/fix some tests plt 901 #1661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13e65e3
Removed unnencessary project creation logic
Jun 4, 2024
e285a18
Attempt to fix flaky test_filtering
Jun 5, 2024
c42d021
Fixed incorrect task test
Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions libs/labelbox/tests/data/annotation_import/test_model_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,16 +168,14 @@ def get_model_run_status():
errorMessage)


def test_model_run_split_assignment_by_data_row_ids(
model_run, dataset, image_url, configured_project_with_one_data_row):
def test_model_run_split_assignment_by_data_row_ids(model_run, dataset,
image_url):
n_data_rows = 2
data_rows = dataset.create_data_rows([{
"row_data": image_url
} for _ in range(n_data_rows)])
data_rows.wait_till_done()
data_row_ids = [data_row['id'] for data_row in data_rows.result]
configured_project_with_one_data_row._wait_until_data_rows_are_processed(
data_row_ids=data_row_ids)
model_run.upsert_data_rows(data_row_ids)

with pytest.raises(ValueError):
Expand Down
3 changes: 2 additions & 1 deletion libs/labelbox/tests/integration/test_filtering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ def project_to_test_where(client, rand_gen):
# other builds simultaneously adding projects to test org
def test_where(client, project_to_test_where):
p_a, p_b, p_c = project_to_test_where
p_a_name, p_b_name = [p.name for p in [p_a, p_b]]
p_a_name = p_a.name
p_b_name = p_b.name

def get(where=None):
date_where = Project.created_at >= p_a.created_at
Expand Down
2 changes: 1 addition & 1 deletion libs/labelbox/tests/integration/test_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def test_task_success_label_export(client, configured_project_with_label):
user = client.get_user()
task = None
for task in user.created_tasks():
if task.name != 'JSON Import' and task.type != 'adv-upsert-data-rows':
if task.name != 'JSON Import' and task.type != 'adv-upsert-data-rows' and task.type != 'mea-label-registration':
break

with pytest.raises(ValueError) as exc_info:
Expand Down
Loading