Skip to content

[SN-0] Updated model chat evaluation to correct name #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 5, 2024
Merged

[SN-0] Updated model chat evaluation to correct name #1649

merged 3 commits into from
Jun 5, 2024

Conversation

Gabefire
Copy link
Collaborator

@Gabefire Gabefire commented Jun 4, 2024 •
edited
Loading

Description

  • The name of Modal chat evaluation got changed updated notebook to match
  • Also removed export V1 to V2 notebook since this is not needed anymore
  • Updated template and contributor guide to make more sense

Type of change

Please delete options that are not relevant.

  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

@Gabefire Gabefire requested a review from a team as a code owner June 4, 2024 16:23
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@Gabefire Gabefire requested a review from paultancre June 4, 2024 16:28
@Gabefire
Copy link
Collaborator Author

Gabefire commented Jun 4, 2024

Also removed migration guide for export v2 to export v1

paultancre
paultancre approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@paultancre paultancre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabefire Gabefire merged commit 7fac32f into develop Jun 5, 2024
4 checks passed
@Gabefire Gabefire deleted the gu/change-LMC branch June 5, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paultancre paultancre paultancre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gabefire @paultancre