Skip to content

[SN-0] Added methods to modify model_configs #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

Gabefire
Copy link
Collaborator

@Gabefire Gabefire commented Jun 3, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

I missed adding modifying model configs

Type of change

Please delete options that are not relevant.

  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@paulnoirel paulnoirel self-requested a review June 3, 2024 17:51
Copy link
Contributor

@paulnoirel paulnoirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@paulnoirel paulnoirel merged commit 01151e9 into develop Jun 3, 2024
4 checks passed
@paulnoirel paulnoirel deleted the gu/chat_eval_modification branch June 3, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants