Skip to content

[PLT-821][PLT-822] Throw user readable errors when creating a custom embedding. #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2024
Merged

[PLT-821][PLT-822] Throw user readable errors when creating a custom embedding. #1644

merged 1 commit into from
Jun 5, 2024

Conversation

sfendell-labelbox
Copy link
Contributor

@sfendell-labelbox sfendell-labelbox commented May 31, 2024 •
edited
Loading

Fixes # (PLT-981) (PLT-982)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@sfendell-labelbox sfendell-labelbox marked this pull request as ready for review May 31, 2024 16:35
@sfendell-labelbox sfendell-labelbox requested a review from a team as a code owner May 31, 2024 16:35
mrobers1982
mrobers1982 reviewed May 31, 2024
View reviewed changes
@sfendell-labelbox sfendell-labelbox changed the title [PLT-981][PLT-982] Throw user readable errors when creating a custom embedding. [PLT-821][PLT-822] Throw user readable errors when creating a custom embedding. May 31, 2024
@sfendell-labelbox sfendell-labelbox requested a review from a team June 5, 2024 16:49
@sfendell-labelbox sfendell-labelbox force-pushed the PLT-821-822 branch 4 times, most recently from 349312c to 5e6e78a Compare June 5, 2024 18:27
mrobers1982
mrobers1982 previously approved these changes Jun 5, 2024
View reviewed changes
@sfendell-labelbox
[PLT-821][PLT-822] Throw user readable errors when creating a custom …
112ae72 
…embedding with an existing name or too few dimensions.
@sfendell-labelbox sfendell-labelbox merged commit 9dff1c2 into develop Jun 5, 2024
15 of 20 checks passed
@sfendell-labelbox sfendell-labelbox deleted the PLT-821-822 branch June 5, 2024 19:01
@sfendell-labelbox sfendell-labelbox restored the PLT-821-822 branch June 5, 2024 20:55
@sfendell-labelbox sfendell-labelbox deleted the PLT-821-822 branch June 5, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrobers1982 mrobers1982 mrobers1982 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfendell-labelbox @mrobers1982