Skip to content

Throw resource not found error for model config methods. #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2024
Merged

Throw resource not found error for model config methods. #1623

merged 1 commit into from
May 23, 2024

Conversation

sfendell-labelbox
Copy link
Contributor

No description provided.

@sfendell-labelbox sfendell-labelbox marked this pull request as ready for review May 21, 2024 19:44
@sfendell-labelbox sfendell-labelbox requested a review from a team as a code owner May 21, 2024 19:44
vbrodsky
vbrodsky previously approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@vbrodsky vbrodsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add an integration test for 1 case?

@sfendell-labelbox sfendell-labelbox force-pushed the rnfe branch 3 times, most recently from 72d1e18 to 208fac4 Compare May 22, 2024 23:22
@sfendell-labelbox
Copy link
Contributor Author

should we add an integration test for 1 case?

Done.

@sfendell-labelbox sfendell-labelbox merged commit a0dec02 into develop May 23, 2024
14 of 19 checks passed
@sfendell-labelbox sfendell-labelbox deleted the rnfe branch May 23, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrodsky vbrodsky vbrodsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfendell-labelbox @vbrodsky