Export V1 to V2 for integration tests #1618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomislav-peharda
previously approved these changes
May 17, 2024
adrian-chang
suggested changes
May 17, 2024
adrian-chang
previously approved these changes
May 22, 2024
|
Waiting for this to merge first #1628 |
|
@Gabefire go ahead and merge |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Gabefire
force-pushed
the
gu/fix_integration_test
branch
2 times, most recently
from
ec968e1 to
58621fc
Compare
Gabefire
force-pushed
the
gu/fix_integration_test
branch
from
58621fc to
81310cd
Compare
|
@adrian-chang, I'll get this merged tomorrow, switching it up to the buffered stream to avoid having to update again. Also, I only touched the integration tests. The data tests will need a follow-up, but this PR will get too large. The data test has V1 methods all over the place. I also have not found a reliable way of exporting a batch |
Gabefire
changed the title
adrian-chang
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.