PR feedback: fix constant name

Author: Val Brodsky

libs/labelbox/src/labelbox/schema/internal/data_row_uploader.py

@@ -2,7 +2,7 @@
 import os
 from concurrent.futures import ThreadPoolExecutor, as_completed
 
-from typing import Iterable, List, Union
+from typing import Iterable, List
 
 from labelbox.exceptions import InvalidQueryError
 from labelbox.exceptions import InvalidAttributeError
@@ -11,7 +11,8 @@
 from labelbox.orm.model import Field
 from labelbox.schema.embedding import EmbeddingVector
 from labelbox.pydantic_compat import BaseModel
-from labelbox.schema.internal.datarow_upload_constants import MAX_DATAROW_PER_API_OPERATION
+from labelbox.schema.internal.datarow_upload_constants import (
+    MAX_DATAROW_PER_API_OPERATION, FILE_UPLOAD_THREAD_COUNT)
 from labelbox.schema.internal.data_row_upsert_item import DataRowUpsertItem
 
 
@@ -31,15 +32,15 @@ def create_descriptor_file(client,
         """
         This function is shared by `Dataset.create_data_rows`, `Dataset.create_data_rows_sync` and `Dataset.update_data_rows`.
         It is used to prepare the input file. The user defined input is validated, processed, and json stringified.
-        Finally the json data is uploaded to gcs and a uri is returned. This uri can be passed to
+        Finally the json data is uploaded to gcs and a uri is returned. This uri can be passed as a parameter to a mutation that uploads data rows
 
         Each element in `items` can be either a `str` or a `dict`. If
         it is a `str`, then it is interpreted as a local file path. The file
         is uploaded to Labelbox and a DataRow referencing it is created.
 
         If an item is a `dict`, then it could support one of the two following structures
             1. For static imagery, video, and text it should map `DataRow` field names to values.
-               At the minimum an `item` passed as a `dict` must contain a `row_data` key and value.
+               At the minimum an `items` passed as a `dict` must contain a `row_data` key and value.
                If the value for row_data is a local file path and the path exists,
                then the local file will be uploaded to labelbox.
 
@@ -73,7 +74,7 @@ def create_descriptor_file(client,
                 a DataRow.
             ValueError: When the upload parameters are invalid
         """
-        file_upload_thread_count = 20
+        file_upload_thread_count = FILE_UPLOAD_THREAD_COUNT
         DataRow = Entity.DataRow
         AssetAttachment = Entity.AssetAttachment
 
@@ -184,7 +185,7 @@ def validate_keys(item):
                 raise InvalidAttributeError(DataRow, invalid_keys)
             return item
 
-        def formatLegacyConversationalData(item):
+        def format_legacy_conversational_data(item):
             messages = item.pop("conversationalData")
             version = item.pop("version", 1)
             type = item.pop("type", "application/vnd.labelbox.conversational")
@@ -215,7 +216,7 @@ def convert_item(data_row_item):
                 return item
 
             if "conversationalData" in item:
-                formatLegacyConversationalData(item)
+                format_legacy_conversational_data(item)
 
             # Convert all payload variations into the same dict format
             item = format_row(item)
@@ -270,9 +271,9 @@ def upload_in_chunks(client, specs: List[DataRowUpsertItem],
             for i in range(0, len(specs), upsert_chunk_size)
         ]
 
-        def _upload_chunk(_chunk):
+        def _upload_chunk(chunk):
             return DataRowUploader.create_descriptor_file(client,
-                                                          _chunk,
+                                                          chunk,
                                                           is_upsert=True)
 
         with ThreadPoolExecutor(file_upload_thread_count) as executor:

libs/labelbox/src/labelbox/schema/task.py

@@ -233,7 +233,7 @@ class DataUpsertTask(Task):
     """
     Task class for data row upsert operations
     """
-    __max_donwload_size: Final = MAX_DATAROW_PER_API_OPERATION
+    MAX_DOWNLOAD_SIZE: Final = MAX_DATAROW_PER_API_OPERATION
 
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
@@ -389,7 +389,7 @@ def _results_as_list(self) -> Optional[List[Dict[str, Any]]]:
         for row in data:
             results.append(row)
             total_downloaded += 1
-            if total_downloaded >= self.__max_donwload_size:
+            if total_downloaded >= self.MAX_DOWNLOAD_SIZE:
                 break
 
         if len(results) == 0:
@@ -405,7 +405,7 @@ def _errors_as_list(self) -> Optional[List[Dict[str, Any]]]:
         for row in data:
             errors.append(row)
             total_downloaded += 1
-            if total_downloaded >= self.__max_donwload_size:
+            if total_downloaded >= self.MAX_DOWNLOAD_SIZE:
                 break
 
         if len(errors) == 0: