Skip to content

Commit d806f11

Browse files
author
Val Brodsky
committed
PR feedback: make UploadManifest a pydantic model
1 parent 326bceb commit d806f11

File tree

2 files changed

+6
-14
lines changed

2 files changed

+6
-14
lines changed

libs/labelbox/src/labelbox/schema/dataset.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -620,7 +620,7 @@ def _exec_upsert_data_rows(
620620
file_upload_thread_count=file_upload_thread_count,
621621
upsert_chunk_size=UPSERT_CHUNK_SIZE)
622622

623-
data = json.dumps(manifest.to_dict()).encode("utf-8")
623+
data = json.dumps(manifest.dict()).encode("utf-8")
624624
manifest_uri = self.client.upload_data(data,
625625
content_type="application/json",
626626
filename="manifest.json")

libs/labelbox/src/labelbox/schema/internal/data_row_uploader.py

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,23 +10,15 @@
1010
from labelbox.orm.model import Entity
1111
from labelbox.orm.model import Field
1212
from labelbox.schema.embedding import EmbeddingVector
13+
from labelbox.pydantic_compat import BaseModel
1314
from labelbox.schema.internal.datarow_upload_constants import MAX_DATAROW_PER_API_OPERATION
1415
from labelbox.schema.internal.data_row_upsert_item import DataRowUpsertItem
1516

1617

17-
class UploadManifest:
18-
19-
def __init__(self, source: str, item_count: int, chunk_uris: List[str]):
20-
self.source = source
21-
self.item_count = item_count
22-
self.chunk_uris = chunk_uris
23-
24-
def to_dict(self):
25-
return {
26-
"source": self.source,
27-
"item_count": self.item_count,
28-
"chunk_uris": self.chunk_uris
29-
}
18+
class UploadManifest(BaseModel):
19+
source: str
20+
item_count: int
21+
chunk_uris: List[str]
3022

3123

3224
class DataRowUploader:

0 commit comments

Comments
 (0)