Skip to content

Conversation

@kab163
Copy link
Collaborator

@kab163 kab163 commented Oct 2, 2025

With Shared memory on, the allocator access example crashes because the example does not use a name in the test allocation. This PR checks for a shared memory resource and allocates accordingly...

@kab163
Copy link
Collaborator Author

kab163 commented Oct 2, 2025

You can reproduce with
cmake -DUMPIRE_ENABLE_BACKTRACE=On -DUMPIRE_ENABLE_FILESYSTEM=On -DUMPIRE_ENABLE_FILE_RESOURCE=On -DUMPIRE_ENABLE_IPC_SHARED_MEMORY=On -DUMPIRE_ENABLE_LOGGING=On -DUMPIRE_ENABLE_MPI=On -DUMPIRE_DEFAULT_SHARED_MEMORY_RESOURCE="POSIX" -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang -DENABLE_MPI=On ../
and then run the allocator_access example - without this PR's changes, it will crash

@kab163
Copy link
Collaborator Author

kab163 commented Oct 6, 2025

@adrienbernede - do you know a way to update the failed test above? It seems like it is not refreshed because looking at the CI everything has passed. Or do I need to rerun everything?

@rhornung67
Copy link
Member

@kab163 I tried rerunning release resources on corona, but that didn't fix it. You have the option to merge without the check being reported as passing in GItHub (bypass rules).

Also, @adrienbernede is on vacation and may be slow to respond.

@kab163
Copy link
Collaborator Author

kab163 commented Oct 8, 2025

Combining with #1005 and will close that other one

@davidbeckingsale davidbeckingsale merged commit b038daa into develop Oct 9, 2025
32 of 34 checks passed
@davidbeckingsale davidbeckingsale deleted the kab163/fix-alloc-access branch October 9, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants