cpp 17: Simplify launch implementations if constexpr #1912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything to do for the OpenMP backend? |
rhornung67
requested review from
MrBurmark,
adayton1,
artv3,
rchen20,
rhornung67 and
smithsg84
I couldn't identify an easy simplification for the OpenMP backend. We could wrap different pragmas with if constexpr, but I don't think it would save that much duplication |
johnbowen42
force-pushed
the
bowen/constexpr-if-simplifications
branch
from
9bab1a8 to
8cbc7c4
Compare
adayton1
approved these changes
Oct 2, 2025
johnbowen42
force-pushed
the
bowen/constexpr-if-simplifications
branch
from
6ef56d4 to
21a74dd
Compare
artv3
reviewed
Oct 7, 2025
| struct is_ForallParamPack_empty<ForallParamPack<>> : std::true_type | ||
| {}; | ||
| } // namespace type_traits | ||
|
|
There was a problem hiding this comment.
maybe we should move this to a "params utils" file?
There was a problem hiding this comment.
I did something similar--I moved all our type trait stuff into its own header
artv3
approved these changes
Oct 7, 2025
|
@artv3 I thought a bit more about our type traits and reorganized the headers a bit. I remembered I made a type traits header for kernel-specific work. I renamed that to be more consistent, and made another TypeTraits.hpp for reduction work. Let me know what you think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies some of the launch SFINAE for cuda/hip. It also moves constexpr branching into parampack calls, simplifying the forall/launch implementations somewhat.