Added exclusive prefix sum to examples #1825
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artv3
reviewed
Apr 21, 2025
examples/prefix_sum.cpp
Outdated
| //---------------------------------------------------------------------------- | ||
| std::cout << "\n Running C-style prefix sum...\n"; | ||
|
|
||
| auto start = std::chrono::high_resolution_clock::now(); |
There was a problem hiding this comment.
There is a RAJA timer that might be useful here. See example:
https://github.com/LLNL/RAJA/blob/develop/exercises/permuted-layout-batch-matrix-multiply_solution.cpp#L105
There was a problem hiding this comment.
Great idea. I've updated the example to use the RAJA timer instead of chrono.
artv3
reviewed
Apr 21, 2025
|
|
||
|
|
||
| //---------------------------------------------------------------------------- | ||
| #if defined(RAJA_ENABLE_CUDA) |
There was a problem hiding this comment.
Unfortunately, I don't have a HIP-compatible environment. Since I wouldn’t be able to verify the results or debug any issues, I’ve opted to leave it out to avoid introducing untested code.
|
@artv3 Thanks for your feedback. I've implemented the requested change. Ready for another review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary