-
Notifications
You must be signed in to change notification settings - Fork 2
Refactor anchor peer removal logic and update FabricNodeForm #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the `--dev=false` argument from the launch configuration. - Updated the anchor peer removal logic in `channel.go` to continue on error instead of returning. - Commented out the peer removal validation in `anchor-peer-config.tsx` for future implementation. - Enhanced `FabricNodeForm` to include an `onChange` prop, allowing parent components to react to form value changes. - Integrated the `onChange` handler in the bulk create nodes page to update node configurations dynamically. These changes improve the flexibility and maintainability of the codebase, particularly in managing anchor peers and form interactions. Signed-off-by: dviejokfs <dviejo@kfs.es>
Signed-off-by: dviejokfs <dviejo@kfs.es>
- Updated the execSystemctl function in the LocalBesu, LocalOrderer, and LocalPeer services to check if sudo is available before executing systemctl commands. - If sudo is available, commands are executed with sudo; otherwise, they are run directly. - This change enhances the flexibility of command execution across different environments. Signed-off-by: dviejokfs <dviejo@kfs.es>
Signed-off-by: dviejokfs <dviejo@kfs.es>
…re for fabric-admin-sdk Signed-off-by: dviejokfs <dviejo@kfs.es>
- Introduced a new API endpoint to retrieve channels for a specific Fabric node. - Added types for channel responses and errors in the types.gen.ts file. - Implemented a React component, FabricNodeChannels, to display the channels associated with a Fabric node. - Updated the NodeDetailPage to include a tab for viewing channels, enhancing the user interface for node management. This feature improves the visibility of channel information for Fabric nodes, allowing users to better manage their network configurations. Signed-off-by: dviejokfs <dviejo@kfs.es>
Signed-off-by: dviejokfs <dviejo@kfs.es>
If SigningKeyId is not in the key when rotating certs in orderer/peers, set it Signed-off-by: dviejokfs <dviejo@kfs.es>
- Introduced a new POST endpoint `/networks/fabric/{id}/update-config` to prepare a configuration update proposal for a Fabric network. - Implemented request and response structures for handling configuration update operations. - Added validation for various operation types and their payloads. - Enhanced Swagger documentation to reflect the new endpoint and its parameters. This feature allows users to manage Fabric network configurations more effectively by supporting multiple operation types for updates. Signed-off-by: dviejokfs <dviejo@kfs.es>
- Migrated various operations related to Fabric network management to new React components, including AddOrgOperation, RemoveOrgOperation, UpdateOrgMSPOperation, and others. - Implemented validation schemas for each operation using Zod to ensure proper data handling. - Enhanced the ChannelUpdateForm to support multiple operations for updating channel configurations. - Removed deprecated components and files related to channel updates, streamlining the codebase. - Updated the UI to improve user experience when managing Fabric network configurations. These changes enhance the modularity and maintainability of the code, allowing for easier updates and feature additions in the future. Signed-off-by: dviejokfs <dviejo@kfs.es>
Signed-off-by: dviejokfs <dviejo@kfs.es>
- Added LogPath field to the service struct in the peer service layer to facilitate logging functionality. - This change improves the ability to track and manage logs associated with service operations. Signed-off-by: dviejokfs <dviejo@kfs.es>
Signed-off-by: David VIEJO <dviejo@kungfusoftware.es>
Signed-off-by: David VIEJO <dviejo@kungfusoftware.es>
- Added new API endpoints for managing Certificate Revocation Lists (CRLs) for organizations, including initializing a CRL, revoking certificates by serial number and PEM data, and retrieving the current CRL. - Implemented corresponding request and response structures for the new endpoints. - Updated the service layer to handle CRL operations, including adding revoked certificates and updating organization CRL information in the database. - Enhanced Swagger documentation to reflect the new CRL-related endpoints and their parameters. These changes improve the functionality and usability of the organization's certificate management system, ensuring better compliance with security standards. Signed-off-by: David VIEJO <dviejo@kungfusoftware.es>
- Added support for versioning in various node configurations, including Fabric peers, orderers, and Besu nodes. - Introduced new API endpoints for managing Certificate Revocation Lists (CRLs) for organizations, including initializing a CRL and revoking certificates. - Enhanced the service layer to handle versioning and CRL operations, ensuring proper data handling and storage. - Updated Swagger documentation to reflect the new endpoints and their parameters. - Improved the user interface to display version information for nodes and added version selection options in forms. These changes enhance the overall functionality and usability of the application, ensuring better management of node configurations and compliance with security standards. Signed-off-by: David VIEJO <dviejo@kungfusoftware.es>
Signed-off-by: David VIEJO <dviejo@kungfusoftware.es>
- Updated the settings management system to allow for creating and updating default settings with command templates for different node types. - Introduced new API endpoints for retrieving and managing settings, including the ability to get and create or update the default setting. - Enhanced the service layer to validate command templates and ensure proper handling of settings data. - Updated Swagger documentation to reflect the new settings endpoints and their parameters. - Improved the user interface to include a new settings page for managing node command templates. - Escape cmd string for peer launchd service These changes enhance the overall functionality and usability of the application, ensuring better management of node configurations. Signed-off-by: David VIEJO <dviejo@kungfusoftware.es>
…ality - Added new API endpoints for updating the Certificate Revocation List (CRL) for organizations, including the ability to post updates via the `/networks/fabric/{id}/organization-crl` endpoint. - Implemented request and response structures for the new CRL update operations, ensuring proper data handling. - Enhanced the service layer to manage CRL updates effectively, including the addition of new database queries for revoked certificates. - Updated Swagger documentation to reflect the new endpoints and their parameters, improving API usability. - Improved the user interface to support CRL management features, including displaying and updating revoked certificates. These changes enhance the overall functionality and usability of the application, ensuring better management of certificate revocation processes. Signed-off-by: David VIEJO <dviejo@kungfusoftware.es>
Signed-off-by: dviejokfs <dviejo@kfs.es>
- Updated the GetChannels method to utilize the new getChannelInfoOnPeer function for improved channel information retrieval. - Implemented error handling for TLS certificate retrieval, peer connection creation, and transaction evaluation. - Added a new method, getChannelInfoOnPeer, to encapsulate the logic for fetching channel information from the peer, ensuring better separation of concerns. - Improved data handling by returning default block number when block information retrieval fails. These changes enhance the functionality and reliability of channel management within the LocalPeer service. Signed-off-by: dviejokfs <dviejo@kfs.es>
- Modified the Swagger documentation to reflect changes in the block retrieval endpoints, including the new `/networks/fabric/{id}/blocks/{blockNum}` and `/networks/fabric/{id}/info` endpoints. - Implemented a new handler for retrieving block details and chain information, ensuring proper error handling and response formatting. - Updated the service layer to support the retrieval of chain information and block transactions, enhancing data management and separation of concerns. - Improved the user interface with new components for displaying block details and an overview of blocks, ensuring a better user experience. These changes enhance the overall functionality and usability of the application, providing better access to blockchain data. Signed-off-by: David VIEJO <dviejo@kungfusoftware.es>
- Updated Swagger documentation with new contact information and improved tag descriptions for better clarity. - Added a new route for serving Swagger UI documentation at `/api/swagger/*`, enhancing accessibility to API specifications. - Introduced a new API documentation page using Redoc for a more user-friendly presentation of API details. - Improved the sidebar navigation to include a link to the API documentation, ensuring users can easily find and access it. These changes enhance the overall usability of the application, providing better access to API documentation and improving user experience. Signed-off-by: dviejokfs <dviejo@kfs.es>
- Updated the `go.mod` and `go.sum` files to reflect changes in dependencies, including upgrades to several packages for improved functionality and security. - Removed outdated dependencies and added new ones to support the latest features and best practices. - Enhanced the GitHub Actions workflow by setting explicit permissions for better security, following the principle of least privilege. These changes ensure the application remains up-to-date with its dependencies and improves the security posture of the CI/CD pipeline. Signed-off-by: dviejokfs <dviejo@kfs.es>
Signed-off-by: dviejokfs <dviejo@kfs.es>
…operations - Introduced a new `errorMessage` field in the Node model to capture error details. - Updated SQL queries to include the `errorMessage` field in relevant operations, including node status updates. - Added a new method `UpdateNodeStatusWithError` to handle status updates along with error messages. - Modified service layer methods to utilize the new error handling capabilities, ensuring proper error reporting during node operations. These changes enhance the application's ability to manage and report node errors effectively, improving overall reliability and user experience. Signed-off-by: David VIEJO <dviejo@kungfusoftware.es>
Signed-off-by: dviejokfs <dviejo@kfs.es>
Signed-off-by: dviejokfs <dviejo@kfs.es>
Signed-off-by: dviejokfs <dviejo@kfs.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--dev=false
argument from the launch configuration.channel.go
to continue on error instead of returning.anchor-peer-config.tsx
for future implementation.FabricNodeForm
to include anonChange
prop, allowing parent components to react to form value changes.onChange
handler in the bulk create nodes page to update node configurations dynamically.These changes improve the flexibility and maintainability of the codebase, particularly in managing anchor peers and form interactions.