-
Notifications
You must be signed in to change notification settings - Fork 48
use notifies :restart #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
glensc
wants to merge
2
commits into
L2G:master
Choose a base branch
from
glensc:pld-notify
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somewhy notifies :reload does not even invoke initscript, and as reload and restart actions are identical in pld this change is okay
|
|
@L2G ping |
|
@L2G ping :) |
|
@L2G ping! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
somewhy
notifies :reloaddoes not even invoke initscript, and as reloadand restart actions are identical in pld this change is okay
i initially thought the problem is identical as #13, but was not,
:immediatelydid not helpalso tried to add
supports [:reload]to service the reload methods just were not called out. tried to debug in chef, but got lost quite soon.anyway, this is safe to add as code what gets invoked is identical