Fix ChoiceType filter with multiple/expanded options #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uh, now I see some more problems with this. I'll close this and get back when I find a better solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Kreyu
I made an attempt to fix #151 and ended up with this. Works okay for me at first glance, but it needs to be tested thoroughly. Of course if you don't like this kind of fix, feel free to close this PR, no problem. Or maybe you will have additional tips/ideas?
I also prepared a separate branch in my demo app (
test/multiple-choices), where these changes can be tested. After checkout, runcomposer installandphp bin/console app:reload-database.If anyone would like to test this PR in their app, it can be done in the following way:
composer update kreyu/data-table-bundleIn the coming week I'll try to test it at my workplace. @j0r1s Could I ask you to test these changes in your environment?