[IgaApplication] nurbs geometry modeler extension to 3D #13465
+184
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
out of curiosity, the 3D IGA elements work now in |
|
Hi Alejandro! |
Comment on lines
164
to
180
| std::string skin_model_part_inner_initial_name = "SkinModelPartInnerInitial"; | ||
| std::string skin_model_part_outer_initial_name = "SkinModelPartOuterInitial"; | ||
| std::string skin_model_part_name; | ||
| if (mParameters.Has("skin_model_part_inner_initial_name")) { | ||
| skin_model_part_inner_initial_name = mParameters["skin_model_part_inner_initial_name"].GetString(); | ||
|
|
||
| KRATOS_ERROR_IF_NOT(mpModel->HasModelPart(skin_model_part_inner_initial_name)) | ||
| << "The skin_model_part '" << skin_model_part_inner_initial_name << "' was not created in the model.\n" | ||
| << "Check the reading of the mdpa file in the import mdpa modeler."<< std::endl; | ||
| } | ||
| if (mParameters.Has("skin_model_part_outer_initial_name")) { | ||
| skin_model_part_outer_initial_name = mParameters["skin_model_part_outer_initial_name"].GetString(); | ||
|
|
||
| KRATOS_ERROR_IF_NOT(mpModel->HasModelPart(skin_model_part_outer_initial_name)) | ||
| << "The skin_model_part '" << skin_model_part_outer_initial_name << "' was not created in the model.\n" | ||
| << "Check the reading of the mdpa file in the import mdpa modeler."<< std::endl; | ||
| } |
There was a problem hiding this comment.
This needs to be updated accordingly (CreateAndAddRegularGrid2d).
There was a problem hiding this comment.
Nice catch Ricky, thanks!
Comment on lines
108
to
109
| void NurbsGeometryModeler::CreateAndAddRegularGrid2D( ModelPart& r_model_part, const Point& A_xyz, const Point& B_xyz, | ||
| const Point& A_uvw, const Point& B_uvw, SizeType OrderU, SizeType OrderV,SizeType NumKnotSpansU, SizeType NumKnotSpansV, bool AddSurfaceToModelPart) |
Comment on lines
-253
to
-255
| void NurbsGeometryModeler::CreateAndAddRegularGrid3D( ModelPart& r_model_part, const Point& A_xyz, const Point& B_xyz, | ||
| const Point& A_uvw, const Point& B_uvw, SizeType OrderU, SizeType OrderV, SizeType OrderW, | ||
| SizeType NumKnotSpansU, SizeType NumKnotSpansV, SizeType NumKnotSpansW ) |
Comment on lines
+107
to
+120
| void CreateAndAddRegularGrid3D( | ||
| ModelPart& rModelPart, | ||
| const Point& A_xyz, | ||
| const Point& B_xyz, | ||
| const Point& A_uvw, | ||
| const Point& B_uvw, | ||
| const SizeType OrderU, | ||
| const SizeType OrderV, | ||
| const SizeType OrderW, | ||
| const SizeType NumKnotSpansU, | ||
| const SizeType NumKnotSpansV, | ||
| const SizeType NumKnotSpansW, | ||
| const bool AddVolumeToModelPart) override; | ||
|
|
|
@andrewgorgi whenever you have time can you review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This is the first of several PRs aimed at extending the current 2D SBM workflow to 3D.
This PR focuses on extending the nurbs_geometry_modeler to support 3D problems.
The next PR will address the extension of CreateSurrogateBoundary for 3D, along with the corresponding tests.