[KratosBio] - Adding Windkessel feature #13448

AMontanino87 · 2025-05-19T16:44:03Z

The pull request implements the Windkessel boundary conditions adding a process to the FluidDynamicBiomedicalApplication.

Also unit test are provided to check everything is working fine

rubenzorrilla · 2025-05-20T05:59:21Z

...cations/FluidDynamicsBiomedicalApplication/python_scripts/apply_windkessel_outlet_process.py

@@ -0,0 +1,138 @@
+import math
+import KratosMultiphysics
+from KratosMultiphysics.assign_scalar_variable_process import AssignScalarVariableProcess


Suggested change

from KratosMultiphysics.assign_scalar_variable_process import AssignScalarVariableProcess

I think you don't need this.

rubenzorrilla · 2025-05-20T06:00:04Z

...cations/FluidDynamicsBiomedicalApplication/python_scripts/apply_windkessel_outlet_process.py

@@ -0,0 +1,138 @@
+import math


Suggested change

import math

I think you don't need this.

rubenzorrilla · 2025-05-20T06:02:17Z

...cations/FluidDynamicsBiomedicalApplication/python_scripts/apply_windkessel_outlet_process.py

+
+        default_settings = KratosMultiphysics.Parameters("""
+        {
+            "mesh_id"            : 0,


Suggested change

"mesh_id" : 0,

This is no longer needed.

rubenzorrilla · 2025-05-20T06:03:55Z

...cations/FluidDynamicsBiomedicalApplication/python_scripts/apply_windkessel_outlet_process.py

+            "resistance1"        : 0.0,
+            "resistance2"        : 0.0,


Suggested change

"resistance1" : 0.0,

"resistance2" : 0.0,

"resistance_1" : 0.0,

"resistance_2" : 0.0,

To follow our standard. Besides, if these are not customary ones in de literature (IDK), I'd try to use a more descriptive name for these two values to ease the use.

rubenzorrilla · 2025-05-20T06:07:53Z

...cations/FluidDynamicsBiomedicalApplication/python_scripts/apply_windkessel_outlet_process.py

+            "compliance"         : 0.0,
+            "venous_pressure"    : 0.0,
+            "initial_pressure"   : 0.0,
+            "pressure_in_mmHg"   : true,


Instead, I'd suggest a pressure_unit field that can take string values as Pa and mmHg (otherwise an error is thrown). By doing so you leave the room open to extend it to other units if required in the future.

rubenzorrilla · 2025-05-20T06:08:45Z

...cations/FluidDynamicsBiomedicalApplication/python_scripts/apply_windkessel_outlet_process.py

+        pres_settings = settings.Clone()
+        pres_settings.RemoveValue("resistance1")
+        pres_settings.RemoveValue("resistance2")
+        pres_settings.RemoveValue("compliance")
+        pres_settings.RemoveValue("initial_pressure")
+        pres_settings.RemoveValue("venous_pressure")
+        pres_settings.RemoveValue("echo_level")


Which is the purpose of pres_settings? You're using it nowhere.

rubenzorrilla · 2025-05-20T06:09:03Z

...cations/FluidDynamicsBiomedicalApplication/python_scripts/apply_windkessel_outlet_process.py

+        pres_settings.RemoveValue("echo_level")
+
+        # Create a copy of the PRESSURE settings to set the EXTERNAL_PRESSURE
+        ext_pres_settings = pres_settings.Clone()


Which is the purpose of ext_pres_settings? You're using it nowhere.

rubenzorrilla · 2025-05-20T06:10:58Z

...cations/FluidDynamicsBiomedicalApplication/python_scripts/apply_windkessel_outlet_process.py

+        for node in self.outlet_model_part.Nodes:
+            node.Set(KratosMultiphysics.OUTLET, True)
+        for condition in self.outlet_model_part.Conditions:
+            condition.Set(KratosMultiphysics.OUTLET, True)


You can use the SetFlag method from the VariableUtils (it is exported to Python) so these two loops are done in parallel.

rubenzorrilla · 2025-05-20T06:12:42Z

...cations/FluidDynamicsBiomedicalApplication/python_scripts/apply_windkessel_outlet_process.py

+            print('Current flow rate', self.current_q1)
+            if self.pressure_in_mmHg:
+                print('Outlet new pressure:', self.modified_p1/self.conv, " mmHg")
+            else:
+                print('Outlet new pressure:', self.modified_p1, " Pa")


Please use the Logger class for this. Browse for KratosMultiphysics.Logger.PrintInfo usages to see many examples.

rubenzorrilla · 2025-05-20T06:14:00Z

applications/FluidDynamicsBiomedicalApplication/tests/apply_windkessel_outlet_process_test.py

+    @classmethod
+    def __GetBlankParameters(cls):
+        return KratosMultiphysics.Parameters("""{
+            "name" : "Processes.KratosMultiphysics.FluidDynamicsBiomedicalApplication.apply_windkessel_outlet_process",
+            "Parameters"    : {
+                "model_part_name" : "OutletModelPart"
+            }
+        }""")


Which is the purpose of these?

rubenzorrilla · 2025-05-20T06:14:55Z

applications/FluidDynamicsBiomedicalApplication/tests/apply_windkessel_outlet_process_test.py

+    @classmethod
+    def tearDown(self):
+        KratosUtilities.DeleteFileIfExisting("test_outlet_table.csv")


I think this is doing nothing.

rubenzorrilla · 2025-05-20T06:15:11Z

applications/FluidDynamicsBiomedicalApplication/tests/apply_windkessel_outlet_process_test.py

@@ -0,0 +1,126 @@
+import csv


Suggested change

import csv

I think you don't need this.

rubenzorrilla · 2025-05-20T06:15:23Z

applications/FluidDynamicsBiomedicalApplication/tests/apply_windkessel_outlet_process_test.py

+import KratosMultiphysics
+import KratosMultiphysics.KratosUnittest as KratosUnittest
+import KratosMultiphysics.kratos_utilities as KratosUtilities
+from KratosMultiphysics.FluidDynamicsApplication import apply_outlet_process


Suggested change

from KratosMultiphysics.FluidDynamicsApplication import apply_outlet_process

I think you don't need this.

rubenzorrilla

Some minor comments, mainly related to things that can be removed.

As a comment aside, why don't we make the process in c++ so we can make the nodal loop in parallel?

rubenzorrilla

Looks nice now! Thanks for taking my comments into consideration.

rubenzorrilla · 2025-06-02T15:39:49Z

@AMontanino87 @soudah I think you forgot to merge this.

AMontanino87 added 3 commits May 19, 2025 10:51

Windkessel process

1ac2200

Merge branch 'master' into Bio-Windkessel

4b63f4d

Added test - working

cf8312e

AMontanino87 requested a review from a team as a code owner May 19, 2025 16:44

AMontanino87 requested review from rubenzorrilla and soudah May 19, 2025 16:44

rubenzorrilla reviewed May 20, 2025

View reviewed changes

rubenzorrilla changed the title ~~[KratosBio] - Adding Windkessek feature~~ [KratosBio] - Adding Windkessel feature May 20, 2025

AMontanino87 added 2 commits May 20, 2025 11:46

Update PR

0da491d

Checked error

cc7443a

rubenzorrilla approved these changes May 27, 2025

View reviewed changes

[KratosBio] - Adding Windkessel feature #13448

Are you sure you want to change the base?

[KratosBio] - Adding Windkessel feature #13448

Conversation

AMontanino87 commented May 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rubenzorrilla left a comment

Choose a reason for hiding this comment

Uh oh!

rubenzorrilla left a comment

Choose a reason for hiding this comment

Uh oh!

rubenzorrilla commented Jun 2, 2025

Uh oh!

Uh oh!