[Core][Analysis stage] Attempting to solve #13350 #13432
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the very first step towards attempting to solve #13350 @loumalouomega @AlejandroCornejo @mcgicjn2
RiccardoRossi
added
Bug
API Breaker
Bugfix
Behaviour Change
loumalouomega
changed the title
|
I will wait for the @KratosMultiphysics/cosimulation and @KratosMultiphysics/geomechanics feedbacks, as well as CI. |
|
luckily grepping for "GetSolver().Predict" gives relatively few calls in the repository: kratos/python_scripts/analysis_stage.py: self._GetSolver().Predict()
applications/GeoMechanicsApplication/python_scripts/piping_analysis.py: self._GetSolver().Predict()
applications/GeoMechanicsApplication/python_scripts/geomechanics_analysis.py: self._GetSolver().Predict()
applications/CoSimulationApplication/tests/structural_mechanics_analysis_remote_controlled.py: self._GetSolver().Predict()
applications/CoSimulationApplication/python_scripts/analysis_stage_with_co_sim_io.py: self._GetSolver().Predict()
applications/ConstitutiveLawsApplication/python_scripts/high_cycle_fatigue_analysis.py: self._GetSolver().Predict()
applications/SwimmingDEMApplication/python_scripts/DEM_coupled_pfem_fluid_dynamics_analysis.py: self._GetSolver().Predict()
applications/OptimizationApplication/python_scripts/filtering/helmholtz_analysis.py: self._GetSolver().Predict()
applications/DEMApplication/python_scripts/custom_material_tests/decompressed_material_triaxial_test.py: self._GetSolver().Predict()
python_scripts/custom_material_tests/decompressed_material_triaxial_test.py: self._GetSolver().Predict()
applications/DEMApplication/python_scripts/custom_material_tests/decompressed_material_triaxial_test.py: self._GetSolver().Predict()
applications/DEMApplication/python_scripts/custom_material_tests/decompressed_material_triaxials_and_bts_tests.py: self._GetSolver().Predict()
applications/DEMApplication/python_scripts/custom_material_tests/decompressed_material_triaxials_and_bts_tests.py: self._GetSolver().Predict()
applications/DEMApplication/python_scripts/custom_material_tests/decompressed_material_triaxials_and_bts_tests.py: self._GetSolver().Predict()
applications/DEMApplication/python_scripts/custom_material_tests/decompressed_material_triaxials_and_bts_tests.py: self._GetSolver().Predict()
applications/DEMApplication/python_scripts/custom_material_tests/decompressed_material_triaxials_and_bts_tests.py: self._GetSolver().Predict()
applications/DEMApplication/python_scripts/custom_material_tests/decompressed_material_triaxials_and_bts_tests.py: self._GetSolver().Predict()
applications/DEMApplication/python_scripts/custom_material_tests/decompressed_material_bts_test.py: self._GetSolver().Predict()
applications/DEMApplication/python_scripts/custom_material_tests/decompressed_material_bts_test.py: self._GetSolver().Predict()
applications/DEMApplication/python_scripts/custom_material_tests/decompressed_material_bts_test.py: self._GetSolver().Predict()
applications/StructuralMechanicsApplication/python_scripts/adaptative_remeshing_structural_mechanics_analysis.py: self._GetSolver().Predict()
applications/StructuralMechanicsApplication/python_scripts/rve_analysis.py: self._GetSolver().Predict()
applications/StructuralMechanicsApplication/python_scripts/structural_mechanics_prebuckling_analysis.py: self._GetSolver().Predict()
applications/ContactStructuralMechanicsApplication/python_scripts/adaptative_remeshing_contact_structural_mechanics_analysis.py: self._GetSolver().Predict()
applications/ContactStructuralMechanicsApplication/python_scripts/adaptative_remeshing_contact_structural_mechanics_analysis.py: self._GetSolver().Predict() so with some luck these are the only analysis stages we should look into |
These are great news. However, note that there could be some "non-standard" calls of the form of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This is the very first step towards attempting to solve #13350
@loumalouomega @AlejandroCornejo @mcgicjn2
This is definitely not ready for merging, it is just to open the iterations
Fixes #13350 (adding this to close issue automatically if this is merged)
🆕 Changelog