-
Notifications
You must be signed in to change notification settings - Fork 261
[FastPR][Core] Remove unused collocation quadratures #13424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Poor quadrature rules, they did not harm |
Looks like still failing |
I know... It's a pity but I'd prefer to have everything consistent across all geometries, both in the usage and in the files we have. We can recover them in the future if required and implement them across all geometries. |
Yes... The point is that I'm trying to separate the changes from the major one and I missed some of them. Let me give it another try. |
Now I think it should work. Note that I required to deactivate the u-epsilon element test (actually the one that triggered the issue w/ the quadratures). @AlejandroCornejo is aware of it. I'll activate it again in the final PR, which will properly address the Lobatto quadratures by having a consistent order across geometries. |
📝 Description
In line to what has been discussed in #13085, this PR targets arranging the KratosCore integration rules. Specifically, this PR removes the unused collocation integration rules.