Skip to content

[FastPR][Core] Remove unused collocation quadratures #13424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2025

Conversation

rubenzorrilla
Copy link
Member

📝 Description
In line to what has been discussed in #13085, this PR targets arranging the KratosCore integration rules. Specifically, this PR removes the unused collocation integration rules.

@rubenzorrilla rubenzorrilla self-assigned this May 13, 2025
@rubenzorrilla rubenzorrilla requested a review from a team as a code owner May 13, 2025 17:45
@rubenzorrilla rubenzorrilla added Cleanup Kratos Core FastPR This Pr is simple and / or has been already tested and the revision should be fast labels May 13, 2025
loumalouomega
loumalouomega previously approved these changes May 13, 2025
loumalouomega
loumalouomega previously approved these changes May 14, 2025
@loumalouomega
Copy link
Member

Poor quadrature rules, they did not harm

@loumalouomega
Copy link
Member

Poor quadrature rules, they did not harm

Looks like still failing

@rubenzorrilla
Copy link
Member Author

Poor quadrature rules, they did not harm

I know... It's a pity but I'd prefer to have everything consistent across all geometries, both in the usage and in the files we have. We can recover them in the future if required and implement them across all geometries.

@rubenzorrilla
Copy link
Member Author

rubenzorrilla commented May 14, 2025

Poor quadrature rules, they did not harm

Looks like still failing

Yes... The point is that I'm trying to separate the changes from the major one and I missed some of them. Let me give it another try.

loumalouomega
loumalouomega previously approved these changes May 14, 2025
@rubenzorrilla
Copy link
Member Author

Now I think it should work. Note that I required to deactivate the u-epsilon element test (actually the one that triggered the issue w/ the quadratures). @AlejandroCornejo is aware of it.

I'll activate it again in the final PR, which will properly address the Lobatto quadratures by having a consistent order across geometries.

@rubenzorrilla rubenzorrilla merged commit 8c52690 into master May 15, 2025
11 checks passed
@rubenzorrilla rubenzorrilla deleted the core/remove-unused-collocation-rules branch May 15, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants