[FastPR][Solid] Moving Gauss-Lobatto line to SolidMechanicsApplication #13422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
In line to what has been discussed in #13085, this PR targets arranging the KratosCore integration rules.
Specifically, this PR moves the
line_gauss_lobatto_3d_2.h
geometry from the core to theSolidMechanicsApplication
. The rationale is that this geometry duplicates theline_3d_2.h
and all across Kratos is only used by one element in this application.Together with the geometry above, it also moves the
line_gauss_lobatto_integration_points.h
to the same application to avoid breaking any current workflow. Note that this does not follow the standard as the expectedGAUSS_LOBATTO_1
(the two endpoints) is named asGAUSS_LOBATTO_2
whileGAUSS_LOBATTO_1
returns a one point Gauss integration rule. To avoid clashing with the core implementation the file has been renamed tosolid_mechanics_line_gauss_lobatto_integration_points.h
.Furthermore, I required to remove the order 6 to 10 rules as these were leveraging the misused
EXTENDED_GAUSS_*
enum. I believe you don't require such high order integration rule.I tried to compile the application to run the tests but it doesn't compile because other reasons related to the testing. Until that point, includes seemed to be OK.