Skip to content

[FastPR][Solid] Moving Gauss-Lobatto line to SolidMechanicsApplication #13422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

rubenzorrilla
Copy link
Member

@rubenzorrilla rubenzorrilla commented May 13, 2025

📝 Description
In line to what has been discussed in #13085, this PR targets arranging the KratosCore integration rules.

Specifically, this PR moves the line_gauss_lobatto_3d_2.h geometry from the core to the SolidMechanicsApplication. The rationale is that this geometry duplicates the line_3d_2.h and all across Kratos is only used by one element in this application.

Together with the geometry above, it also moves the line_gauss_lobatto_integration_points.h to the same application to avoid breaking any current workflow. Note that this does not follow the standard as the expected GAUSS_LOBATTO_1 (the two endpoints) is named as GAUSS_LOBATTO_2 while GAUSS_LOBATTO_1 returns a one point Gauss integration rule. To avoid clashing with the core implementation the file has been renamed to solid_mechanics_line_gauss_lobatto_integration_points.h.

Furthermore, I required to remove the order 6 to 10 rules as these were leveraging the misused EXTENDED_GAUSS_* enum. I believe you don't require such high order integration rule.

I tried to compile the application to run the tests but it doesn't compile because other reasons related to the testing. Until that point, includes seemed to be OK.

@rubenzorrilla
Copy link
Member Author

Pinging @lluis-mv to be sure you get notified.

@lluis-mv
Copy link
Member

Pinging @lluis-mv to be sure you get notified.

hey thanks for letting me now. (and yes I am working to fix the tests of the app, but, I still have one test to fix and i do not manage to...)

@rubenzorrilla rubenzorrilla merged commit b3d4b28 into master May 19, 2025
11 checks passed
@rubenzorrilla rubenzorrilla deleted the solid/moving-lobatto-line branch May 19, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants