Skip to content

[Core][StructuralMechanicsApplication] Refactor solid element methods to ensure consistent Jacobian computation for Updated and Total Lagrangian elements #13367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

loumalouomega
Copy link
Member

📝 Description

Related #13350

This PR refactors several files in the StructuralMechanicsApplication related to solid elements, with the main objective of ensuring consistent computation of the Jacobian for both Updated and Total Lagrangian elements. I remember that that inconsistency is something we (@RiccardoRossi and I) discussed at the time. We should discuss this.

The changes include:

  1. BaseSolidElement:

    • Refactored the CalculateDeltaDisplacement method to use GeometryUtils::CalculateDeltaDisplacement, which ensures consistent and accurate computation of displacement increments.
    • Updated type definitions in the header file to use using instead of typedef for clarity and consistency.
    • Cleaned up code, improved the consistency of function signatures, and removed unnecessary lines.
  2. UpdatedLagrangian:

    • Removed the deprecated CalculateDerivativesOnReferenceConfiguration method and its declaration to streamline the code and focus on necessary computations.
    • Fixed the header file to include all necessary dependencies and ensure proper functionality.
  3. GeometryUtilities:

    • Improved the handling of displacement differences to ensure accurate Jacobian calculations, particularly addressing issues when the mesh is not moved, such as during non-linear iterations.

The overall goal of these changes is to provide a more consistent and robust method for calculating the Jacobian in both the Updated and Total Lagrangian formulations.

🆕 Changelog

@loumalouomega
Copy link
Member Author

Well, this is failing as expected

@loumalouomega
Copy link
Member Author

I will close this, as not the actual solution

@loumalouomega loumalouomega deleted the structural/consistent-initial-configuration-computation branch May 6, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant