[Core][StructuralMechanicsApplication] Refactor solid element methods to ensure consistent Jacobian computation for Updated and Total Lagrangian elements #13367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Related #13350
This PR refactors several files in the
StructuralMechanicsApplication
related to solid elements, with the main objective of ensuring consistent computation of the Jacobian for both Updated and Total Lagrangian elements. I remember that that inconsistency is something we (@RiccardoRossi and I) discussed at the time. We should discuss this.The changes include:
BaseSolidElement:
CalculateDeltaDisplacement
method to useGeometryUtils::CalculateDeltaDisplacement
, which ensures consistent and accurate computation of displacement increments.using
instead oftypedef
for clarity and consistency.UpdatedLagrangian:
CalculateDerivativesOnReferenceConfiguration
method and its declaration to streamline the code and focus on necessary computations.GeometryUtilities:
The overall goal of these changes is to provide a more consistent and robust method for calculating the Jacobian in both the Updated and Total Lagrangian formulations.
🆕 Changelog