Quick fixes and tests #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
approved these changes
Jun 12, 2025
Mr3zee
force-pushed
the
documentation-update
branch
from
0a0d4bb to
125f9ea
Compare
Mr3zee
force-pushed
the
quick-fixes-and-tests
branch
from
d455f9a to
7f9d06b
Compare
Mr3zee
force-pushed
the
quick-fixes-and-tests
branch
from
7f9d06b to
5d1590e
Compare
Mr3zee
added a commit
that referenced
this pull request
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
kRPC
Problem Description
Some tests are missing, some changes were left out by previous PRs
Solution
InitializedKrpcClientcloseandawaitCompletionforKrpcClientandKrpcServer