Skip to content

Cold Ktor client #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

Cold Ktor client #348

merged 1 commit into from
Jun 12, 2025

Conversation

Mr3zee
Copy link
Collaborator

@Mr3zee Mr3zee commented Jun 6, 2025

Strict mode Migration
A series of changes to simplify kRPC protocol

  • Remove fields support
  • Remove stream scopes
  • Simplify lifetime management
  • Cold RPC clients creation
  • Deprecated declarations cleanup
  • Documentation update for previous changes

Subsystem
Krpc Ktor

Problem Description
Ktor Krpc client requires invokavion of .rpc method which is suspending. In some cases that might be bad UX.

Solution
Allow for a cold client creation

@Mr3zee Mr3zee self-assigned this Jun 6, 2025
@Mr3zee Mr3zee added the feature New feature or request label Jun 6, 2025
@Mr3zee Mr3zee marked this pull request as ready for review June 10, 2025 14:39
@Mr3zee Mr3zee requested a review from e5l June 10, 2025 14:39
Base automatically changed from lifetime to enforce-strict-mode June 11, 2025 08:55
@Mr3zee Mr3zee requested a review from e5l June 11, 2025 19:02
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Mr3zee Mr3zee merged commit 6f07b0f into enforce-strict-mode Jun 12, 2025
1 check passed
@Mr3zee Mr3zee deleted the cold-client branch June 12, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants