Skip to content

fix: fix gorelease build file #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

EwertonLuan
Copy link
Contributor

@EwertonLuan EwertonLuan commented May 18, 2025

[Fix build files]

The builds were failing because and removed flag --rm-dist, this was deprecated and removed and since the build was using latest it start to fail.

Changes

  • Update --rm-dist to --clean
  • fix version to '~> v2' avoiding major updates and break changes
  • fix gorelase warning only version: 2 configuration files are supported, yours is version: 0, please update your configuration by setting version: 2
  • fix github action to use on-> release-> type, tags are only available on push events, the pipelines were triggered 3 times by the release events types, release.published and released. One succeed and the other filled because the files already exists.

Tests

tested pipeline -> https://github.com/EwertonLuan/mmt/actions/runs/15097824341
release with binaries -> https://github.com/EwertonLuan/mmt/releases/tag/v2.0.4

Closes #146

[Brief description of the fix.]

Type:

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Camera:

  • GoPro
  • Insta360
  • DJI
  • Android
  • This PR adds a new camera

Component:

  • Core logic
  • Import
  • Merging
  • Firmware Update
  • Video Manipulation

Checklist before approval:

  • Linter pass
  • Build pass

…se types and not duplicate actions pipelines and fix warnin related to gorelease file version
tags:
- 'v*'
types: [published]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you would prefer still use tags would need to update to something like

on:
  push:
    tags:
      - v**

But since the files are add in the release I thought this was the intention

doc

@KonradIT
Copy link
Owner

Hi, thank you for the fix.

@KonradIT KonradIT merged commit c9e9af5 into KonradIT:development May 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloading a v2 release is either broken or far too confusing
2 participants