Allow printf in shaders #407
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 11, 2024 11:15
Signed-off-by: koubaa <koubaa@github.com>
Signed-off-by: koubaa <koubaa@github.com>
Signed-off-by: koubaa <koubaa@github.com>
Signed-off-by: koubaa <koubaa@github.com>
ThePseudo
reviewed
Apr 15, 2025
| @@ -14,6 +14,30 @@ namespace py = pybind11; | |||
| // used in Core.hpp | |||
| py::object kp_trace, kp_debug, kp_info, kp_warning, kp_error; | |||
|
|
|||
| static void kp_log(int level, const std::string& msg) { | |||
There was a problem hiding this comment.
Although it is already understandable, I would put an enum for the level (just to have a meaningful level name from "trace" to "error")
ThePseudo
reviewed
Apr 15, 2025
| computeInstanceCreateInfo.enabledLayerCount = | ||
| static_cast<uint32_t>(validLayerNames.size()); | ||
| computeInstanceCreateInfo.ppEnabledLayerNames = validLayerNames.data(); | ||
| computeInstanceCreateInfo.setEnabledLayerCount( |
There was a problem hiding this comment.
Same for next ones but I like the usage of the VKCPP capabilities
ThePseudo
reviewed
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change gets closer to letting shader printf work in the idiomatic way for vulkan. If an env var is set, the appropriate layer is included. Together with #406, where device extensions can be selected, this almost works from the python side. There is still one problem which I don't fully understand yet whereby shader printf do not appear in the log (even if I set the information bit in on the debug logger), but it does appear if I set the (now considered obsolete) vulkan env var DEBUG_PRINTF_TO_STDOUT=1.
Note - the python logging objects were used without acquiring the GIL - which is invalid use of pybind11 that leads to race conditions. I encountered many of those while I was working on this branch. This PR fixes those issues by explicitly acquiring the GIL during the log methods.
One thing I didn't yet look into is this note: