Skip to content

Yandex dimmer YNDX-00530 #9017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 21, 2025
Merged

Yandex dimmer YNDX-00530 #9017

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2e07a2b
reportAttribute modernExtend
kirovilya Mar 10, 2025
8b26abc
[autofix.ci] apply automated fixes
autofix-ci[bot] Mar 10, 2025
1b5b02e
configure
kirovilya Mar 10, 2025
c5e04a2
[autofix.ci] apply automated fixes
autofix-ci[bot] Mar 10, 2025
7378ba4
remove reportAttribute
kirovilya Mar 12, 2025
5b015cb
Yandex dimmer
kirovilya Mar 18, 2025
c12a34f
Merge branch 'Koenkk:master' into master
kirovilya Mar 18, 2025
b17b09e
level reporting config for m.light
kirovilya Mar 20, 2025
a53aa93
fix
kirovilya Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions src/devices/yandex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ function YandexCluster(): ModernExtend {
powerType: {ID: 0x0003, type: Zcl.DataType.ENUM8},
ledIndicator: {ID: 0x0005, type: Zcl.DataType.BOOLEAN},
interlock: {ID: 0x0007, type: Zcl.DataType.BOOLEAN},
buttonMode: {ID: 0x0008, type: Zcl.DataType.ENUM8},
},
commands: {
switchMode: {
Expand All @@ -113,6 +114,10 @@ function YandexCluster(): ModernExtend {
ID: 0x07,
parameters: [{name: "value", type: Zcl.DataType.UINT8}],
},
buttonMode: {
ID: 0x08,
parameters: [{name: "value", type: Zcl.DataType.UINT8}],
},
},
commandsResponse: {},
});
Expand Down Expand Up @@ -431,4 +436,48 @@ export const definitions: DefinitionWithExtend[] = [
}),
],
},
{
zigbeeModel: ["YNDX-00530"],
model: "YNDX_00530",
vendor: "Yandex",
description: "Dimmer",
extend: [
YandexCluster(),
m.light({
effect: true,
powerOnBehavior: true,
configureReporting: true,
}),
m.lightingBallast(),
binaryWithSetCommand({
name: "led_indicator",
cluster: "manuSpecificYandex",
attribute: "ledIndicator",
valueOn: ["ON", 1],
valueOff: ["OFF", 0],
setCommand: "ledIndicator",
zigbeeCommandOptions: {manufacturerCode},
description: "Led indicator",
entityCategory: "config",
}),
enumLookupWithSetCommand({
name: "button_mode",
cluster: "manuSpecificYandex",
attribute: "buttonMode",
setCommand: "buttonMode",
zigbeeCommandOptions: {manufacturerCode},
description: "Dimmer button mode",
lookup: {
general: 0x00,
alternative: 0x01,
},
entityCategory: "config",
}),
m.reportAttribute({
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not already done with:

m.light({
                effect: true,
                powerOnBehavior: true,
                configureReporting: true,
            }),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. The default minimum period in the report is 10 seconds, and here I change it to the minimum.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I add reporting parameters for each attribute to m.light, the code will grow. Therefore, I decided to make a universal reporting that can be used in various cases.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is nicer to put it in m.light, in this was you don't need to look in multiple places for the config (and also the execution order is not guaranteed)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

cluster: "genLevelCtrl",
attribute: "currentLevel",
config: {min: "MIN", max: "MAX", change: 1},
}),
],
},
];
13 changes: 13 additions & 0 deletions src/lib/modernExtend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2692,4 +2692,17 @@ export function bindCluster(args: {cluster: string | number; clusterType: "input
return {configure, isModernExtend: true};
}

export function reportAttribute(args: {
cluster: string | number;
attribute: ReportingConfigAttribute;
config: ReportingConfigWithoutAttribute;
access?: Access;
endpointNames?: string[];
}): ModernExtend {
const configure: Configure[] = [
setupConfigureForReporting(args.cluster, args.attribute, args.config, args.access || ea.STATE_GET, args.endpointNames),
];
return {configure, isModernExtend: true};
}

// #endregion