Ported Custom Philips Clusters From Herdsman To ModernExtends

[danieledwardgeorgehitchcock]

This is a draft pull request intended to begin the moving of manufacturerSpecific clusters out of the Herdsman Clusters specification and into the modernExtends format in preparation for some larger re-factoring taking place for the work done by @chrivers in the Bifrost project.

At present, this is just a lift and drop of the cluster specs as they are in Herdsman (will create a separate PR in that repo for removal).

Once I have got this over the line, I will begin porting across the newly documented cluster attributes / commands / responses

[Koenkk]

This code is only executed for Philips devices using philipsLight(), there are also e.g. plugs and motion sensors that have these clusters. Maybe we should create a new philipsCustomClusters() modern extend?

[danieledwardgeorgehitchcock]

Thanks for the review! I'll get right on it!

[danieledwardgeorgehitchcock]

This code is only executed for Philips devices using philipsLight(), there are also e.g. plugs and motion sensors that have these clusters. Maybe we should create a new philipsCustomClusters() modern extend?

This is looking like a larger job than I expected.

My thoughts so far:

• Cluster FC00 can be stripped out from Light as, I cannot find any light fixture that uses it
• I can port Philips only elements from fromZigbee and toZigbee into the new modernExtends light definition as part of this request (although, I am only seeing ones associated with switches so, this may have already been done)

What I am hesitant on doing (for now) is to do as you suggested and create a new extends definition for Switches which uses the FC00 cluster as part of this PR - I am trying to keep PR's as small and non-monolithic as possible so that things are easier to test (and revert if needed)

My suggestion (if you'd be happy), is for me to do the changes in the bullets above and keep that as the scope of this PR.

Actions for subsequent PR's:

• Create switch modernExtends and port FC00 cluster and port definitions from other areas
• Remove cluster definitions from Herdsman (done, PR raised)
• Re-Name clusters to more descriptive names
• Add additional cluster attributes / commands that have been documented by Christian in the Bifrost project

[Koenkk]

I don't see much risk with adding the custom clusters through the modern extend, could you elaborate more where you got stuck?

[danieledwardgeorgehitchcock]

Maybe I am just misunderstanding and going off on a tangent.

Here is what I have done so far:
https://github.com/danieledwardgeorgehitchcock/zigbee-herdsman-converters/tree/philips_switch_modern_extends

[Koenkk]

I would not expect this: danieledwardgeorgehitchcock@2b7cecf

What I expected:

• Add a new modern extend to

  zigbee-herdsman-converters/src/lib/philips.ts

  Line 57 in 4b7c15c

  const philipsModernExtend = {

  , customClusters which only does a m.deviceAddCustomCluster for every cluster
• Add the modern extend to every Philips device, so every device in philips.ts has extend: [philips.m.customClusters(), ...]
• Also add it to

  zigbee-herdsman-converters/src/lib/generateDefinition.ts

  Line 303 in 4b7c15c

  generated.push(new ExtendGenerator({extend: philips.m.light, args, source: "m.light", lib: "philips"}));

[danieledwardgeorgehitchcock]

I did think it was a lot! 😂 Hence why I branched..

I will have another go..

There is some stuff I've done though that I may bring over to other PRs.. so, I don't think it's necessarily wasted effort

[danieledwardgeorgehitchcock]

Could you look at

zigbee-herdsman-converters/src/lib/philips.ts

Line 203 in e8acd7f

customClusterFC00: () => {

where I have had a go at splitting it out? Please let me know if I am in the right ballpark - I am new to the modernExtends concept and out of my comfort zone here :-)

[Koenkk]

where I have had a go at splitting it out?

I don't understand what you mean with this, could you elaborate a bit more on this?

[Koenkk]

Note to self; after this merge Koenkk/zigbee-herdsman#1326

[github-actions]

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

[chrivers]

This isn't stale, but I can't remove the label. @Koenkk, a little help please? :)

[github-actions]

This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days