Add Clear button for non required args #7775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
franknoirot
reviewed
Jul 15, 2025
| @@ -38,6 +42,10 @@ function CommandBarHeaderFooter({ | |||
| }, [selectedCommand]) | |||
| const isReviewing = commandBarState.matches('Review') | |||
| const [showShortcuts, setShowShortcuts] = useState(false) | |||
| const isCurrentArgRequired = | |||
There was a problem hiding this comment.
Nice, I support this, this was the only thing I was curious about. Good thinking
There was a problem hiding this comment.
Dope! Thank you. Added the pw test steps, this is ready to go now
jacebrowning
approved these changes
Jul 17, 2025
pierremtb
deleted the
pierremtb/issue7772-Add-Clear-button-for-non-required-args
branch
franknoirot
reviewed
Jul 17, 2025
| @@ -659,6 +727,8 @@ theta = 45deg | |||
| ) | |||
| }) | |||
|
|
|||
| // TODO: add pw test for clear non-required arg button | |||
There was a problem hiding this comment.
@pierremtb I think you've done this above and the TODO can be removed.
There was a problem hiding this comment.
https://github.com/KittyCAD/modeling-app/pull/7814/files you're right ty!
pierremtb
added a commit
that referenced
this pull request
Jul 17, 2025
pierremtb
added a commit
that referenced
this pull request
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7772