#7690 Plane selection improvements #7707
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| const artifact = findOperationArtifact( | ||
| props.item, | ||
| kclManager.artifactGraph | ||
| ) | ||
| void selectOffsetSketchPlane(artifact) |
There was a problem hiding this comment.
The function selectOffsetSketchPlane now returns a Promise<Error | boolean> instead of a Promise<boolean>, but this call doesn't handle potential errors. Consider updating to:
const result = await selectOffsetSketchPlane(artifact);
if (err(result)) {
console.error(result);
return;
}This ensures errors are properly logged and handled before proceeding.
| void selectOffsetSketchPlane(artifact) | |
| const result = await selectOffsetSketchPlane(artifact); | |
| if (err(result)) { | |
| console.error(result); | |
| return; | |
| } |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
I think the bot is right there @andrewvarga ?
|
@andrewvarga if it's ready to go could you remove the WIP prefix in the title? |
|
I don't know if it's gh or not but the diff doesn't look right |
andrewvarga
changed the title
Sure, I was working on the context menu related UX fixes but it can be on another PR. Which part of the diff doesn't look right? To me the diff on |
|
@andrewvarga Oh yeah no problem at all. In this case I think the "Convert to draft" button would be best to signal the WIP status and most importantly prevent us from approving and merging hahaha |
You're right, I'll start using that! |
| const artifact = findOperationArtifact( | ||
| props.item, | ||
| kclManager.artifactGraph | ||
| ) | ||
| void selectOffsetSketchPlane(artifact) |
There was a problem hiding this comment.
I think the bot is right there @andrewvarga ?
Fixes #7690 a follow up on #7609