-
Notifications
You must be signed in to change notification settings - Fork 83
feature: Project Explorer update, first pass. #7656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nadr0
wants to merge
142
commits into
main
Choose a base branch
from
nadro/gh-6878/no-virtual-list
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
142 commits
Select commit
Hold shift + click to select a range
fcf584e
chore: saving off skeleton progress... need to write unit tests do so…
nadr0 320a7e1
chore: big cleanup, typing, adding comments, better structure
nadr0 c1e0206
chore: moved selected row and opened rows up a level in the react com…
nadr0 a5768a0
feature: button to collapse all folders
nadr0 4983c54
feat: implemented projet explorer refresh
nadr0 24d5bbd
feat: sort was not sorting folders and files at each level, selection…
nadr0 c8bba25
chore: unable to implement insert at index, need to come back to this…
nadr0 23b12de
chore: css pointer and hover
nadr0 e45eb57
chore: adding custom folder icon
nadr0 746fbcb
chore: adding opened icon
nadr0 5106e3f
feat: adding line for indentation visual
nadr0 424d2aa
fix: react key warning
nadr0 90b6c90
fix: trying to make progress on selection, active index, keyboard, an…
nadr0 41ebfa0
chore: aria support
nadr0 c4ec055
chore: implementing removing the click area when you click outside th…
nadr0 b02da6a
fix: fmt?
nadr0 5e08013
chore: active index logic, keyboard arrow logic
nadr0 01337c1
chore: outline offset logic
nadr0 26e0fba
chore: some arrow key usage, need to move data up a level I think
nadr0 5c97b3d
chore: more data up a level
nadr0 b5b1d7d
fix: improving file/folder structure and resolving typescript errors
nadr0 bc2ba07
chore: clean up
nadr0 8b9776c
fix: fmt
nadr0 9338dde
fix: hmm trying to deal with state management
nadr0 d728667
fix: moving the filter logic up
nadr0 0b24f0a
chore: keyboard interactions
nadr0 e429ff7
fix: ope
nadr0 bc58484
fix:commiting broken context menu
nadr0 7ef9b25
fix: some testing code for dragging
nadr0 9308ffe
chore:debug with react dev tools
nadr0 f0fb454
fix: dang
nadr0 48f68f6
fix: context menu selection outline
nadr0 199fffc
fix: fmt
nadr0 14ef435
fix: moved path into the file entry
nadr0 c1dafdd
fix: saving off renaming progress
nadr0 12a4b44
fix: fmt
nadr0 6ac164d
chore: saving off some progress for the renaming, need a new systemio…
nadr0 5e972eb
fix: renaming folders!
nadr0 b6adb79
fix: blocking arrow keys on renaming
nadr0 f2374d7
chore: renaming files with the systemio
nadr0 4cb9184
fix: force renaming with extensions since they can rename their file …
nadr0 deab673
fix: deleting file or folder
nadr0 ff0b688
fix: deleting folders
nadr0 d25ecfc
fix: open in new window
nadr0 c7c3d4b
fix: fixing linter and ts issues
nadr0 e2b49e3
fix: more tsc error fixing
nadr0 40198b0
fix: renaming handlers
nadr0 af34dc7
fix: on context menu open
nadr0 6234e23
fix: more ts fixes
nadr0 e2b2b80
fix: more tsc fixes
nadr0 cec90e7
fix: need to fix some major event typescript handling
nadr0 06f0276
fix: testing with multiples!
nadr0 f1d9380
fix: handling blur,focus for the containers to start tabbing and usin…
nadr0 ff3a0f6
fix: updating icons
nadr0 950aa13
fix: placeholders and showing them for add file or foldeR
nadr0 dddc7e3
fix: big add file and folder logic
nadr0 e14bfdf
fix: fmt
nadr0 6442e4a
fix: implemented adding files and folders at the activeIndex level in…
nadr0 ba5b113
chore: css fixes based on Frank's design
nadr0 7fbc71e
chore: more css updates
nadr0 5fcc99d
chore: css to know what region you are renaming or adding a new file in
nadr0 05bc96b
chore: improving some css and layout issues
nadr0 d81bd6d
fix: the caching of the callback from the context menu borked the fun…
nadr0 5679998
chore: trying to layout the project explorer in the tab properly
nadr0 9fbcd1c
fix: proxy header actions
nadr0 e12f5ce
fix: clear internal state across projects switching
nadr0 185c666
fix: ope, opening any file known to man!
nadr0 8dfeab7
fix: only running on kcl files and fmt
nadr0 137bee9
fix: parent path shows error
nadr0 d53cf66
fix: fmt
nadr0 422908d
chore: opening parent folders all the way down to the file that is lo…
nadr0 9449825
fix: error handling missing file scenario
nadr0 bf838e0
fix: getting rid of debug index
nadr0 4f499ce
chore: placeholder is empty string so the fake name is not shown to t…
nadr0 299d54f
fix: keep placeholder if it is a real file, only hide it on the fake …
nadr0 9976f5d
fix: auto fmt
nadr0 9033edb
chore: improved copy for renaming folders
nadr0 0ccd14f
chore: updated and tested copy for renaming file names
nadr0 414d111
chore: updated copy for creating a blank kcl file
nadr0 eded753
chore: fixed copy for creating a blank folder:
nadr0 0f3c1d0
chore: redirect to file after creation
nadr0 59c008c
chore: redirect on rename file at any tree level
nadr0 47fba02
fix: auto fmt
nadr0 9e16737
fix: only navigate on rename if the file you are renaming is the one …
nadr0 3817d60
fix: redirect only on rename, need to have a cleaner path library and…
nadr0 1ba18dd
fix: fmt
nadr0 aeb57c8
fix: adding comments
nadr0 75e8550
fix: delete and navigate
nadr0 9d45de9
fix: fmt
nadr0 22ce9b4
fix: on enter it opens file
nadr0 4fe0eb3
fix: removing debug package
nadr0 bd62f14
fix: fixing tsc errors
nadr0 8c281cf
fix: resolving tsc errors
nadr0 ebf1ec5
fix: home should not change
nadr0 b733722
fix: fixing bug with enter with project loader name ref
nadr0 30e9410
fix: fixing height to allow clicking empty space then the arrow keys …
nadr0 bc6b44e
fix: ope testing code when helping adam got here
nadr0 0fce24e
fix: adding toast since it is using a create file and navigate functi…
nadr0 7da6d7a
fix: typo
nadr0 ab29916
fix: trying to fix more tsc errors
nadr0 821af16
chore: readonly and navigation booleans
nadr0 332cc27
fix: aria set size and position in set were computed wrong
nadr0 9b90c98
chore: deleted the old file tree:
nadr0 4d7623b
chore: filemachineprovider still has useful code, it is now modelingp…
nadr0 cdac1f8
fix: formatter
nadr0 519ed1d
fix: adding some unit tests
nadr0 bb4ef3f
chore: adding unit tests for adding the placeholders
nadr0 5330492
fix: 2 e2e tests, made a new helper function for the future
nadr0 327bcfa
fix: fixing another e2e test
nadr0 ee44a4f
fix: finally found the right helper function, don't know why this is …
nadr0 95fe5a3
fix: e2e tests...
nadr0 6927d26
fix: updating button role to the treeitem
nadr0 142798a
fix: fixing e2e test
nadr0 4adb01f
ope: I need the delete confirmation
nadr0 ce9a51c
fix: local state for modal confirmation but the action takes place on…
nadr0 0d925d2
fix: fixing more e2e tests
nadr0 5183934
fix: fixing more e2e tests
nadr0 2b838af
chore: added insert on importable files
nadr0 d834e4b
fix: fmt
nadr0 86aec2d
fix: fixing another e2e test
nadr0 4987297
fix: fixing locator for another e2e test
nadr0 f1bbbfc
fix: another e2e test
nadr0 ccc7ec9
fix: I thought I fixed this typo already
nadr0 2fd87fa
fix: make ENOENT a warning, it isn't a real error
nadr0 d867d82
fix: last known index so you can swap file/folder when creating in th…
nadr0 9ea06ae
fix: fixing another locator for e2e test
nadr0 eb1a541
chore: Jest to vitestga!
nadr0 ca3d467
fix: this is covered in the unit test runner
nadr0 55625b5
fix: cleanup testing code
nadr0 dcbdf9f
Fix tsc errors
franknoirot 6750f36
fix: merging main
nadr0 2bee64b
fix: moved file so the url is found
nadr0 5ec5759
fix: ope, wrong function
nadr0 8122586
fix: merging main
nadr0 6e1686d
Merge branch 'main' into nadro/gh-6878/no-virtual-list
nadr0 3e55b8d
fix: addressing PR comments, implementing close folder if you are on …
nadr0 8c46042
chore: learning and implementing unit component testing, got some goo…
nadr0 bb85e8e
chore: adding more ProjectExplorer tests, added an event click test! …
nadr0 2d8806f
chore: adding a unit test for clicking collapse button in ProjectExpl…
nadr0 e943d3b
chore: adding more unit test scenarios I manually tested but now in r…
nadr0 7e3ef9c
chore: added unit test for opening and closing folders to check child…
nadr0 50bfec0
Merge branch 'main' into nadro/gh-6878/no-virtual-list
nadr0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All jest unit test component stuff is merged into
vitest
since it is compatible and supports more of our repository level configurations.