constraint colors #7647
constraint colors #7647
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
I think it's a great idea to make it feel a little more like SW! Things don't seem super stable locally for me, especially when the path is closed, see video and the errors about close. Happy to help reproduce if you have specific things I should try
Screen.Recording.2025-07-01.at.11.46.50.AM.mov
|
Thanks @pierremtb I think I solved it? The noise is gone, but I never had trouble with the segments not getting coloured correctly so not sure, maybe it was your sketch, either way could you try it again? |
| callExpName?: string | ||
| isFullyConstrained: boolean | ||
| }): number { | ||
| if (isSelected) return 0x0000ff // Blue for selected |
There was a problem hiding this comment.
Doesn't have to be in this PR: I was thinking about the two different blues we have now on this branch: zoo blue for unconstrained, and that full blue for selected.
So I went looking at other apps and Onshape uses their 'selection' color to show selected segments, which is the same color as when they select faces. I think that makes a ton of sense right? Same color for us as highlighted code or scene selection would be dope here
There was a problem hiding this comment.
There's only two blue becaue I use the "primary color" for the unconstrained blue, which is blue by default, but you can see it's orange in my vid in the PR description.
That's really just a side note though, maybe I'll make hover and selected two shades of yellow, since that's what's selected is engine side. Good suggestion.
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/two-factor-authentication |
There was a problem hiding this comment.
Recording.2025-07-18.132008.mp4
@Irev-Dev I'm wondering if I'm just running into perf issues here on windows? I keep hitting blinking colors and I'm afraid that could be more confusing than helpful? Potentially could be worth rebasing once @andrewvarga 's PR gets in and seeing if that makes a difference?
I pushed a fix for npm tsc btw, should be back to green
@pierremtb Hmm that is pretty annoying. I think it's more likely to be a race made worse by perf perhaps. I haven't been able to replicate it. But I agree don't want to merge unless it's consistent. I did make one more commit that could be the source of a race, where colors were only applied on update not create (I had thought this was good to keep things simple with how much some extra params need to be passed around, but possible the update is not getting called sufficiently when there'se perf issues not sure.) so if you wanted you could try it again?
Thank you. |
|
@Irev-Dev Thanks, bummer we keep delaying this. I did have a look quick on my mac here, and can still reproduce. But only in electron ( |
Screenshare.-.2025-07-01.5_30_38.PM.mp4