Skip to content

remove entity_ids response from patterns and mirrors #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

remove entity_ids response from patterns and mirrors #888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions modeling-cmds/src/ok_response.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,9 +796,6 @@ define_ok_modeling_cmd_response_enum! {
/// The response from the `EntityClone` command.
#[derive(Debug, Serialize, Deserialize, Clone, JsonSchema, ModelingCmdOutput)]
pub struct EntityClone {
/// The UUIDs of the entities that were created.
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub entity_ids: Vec<Uuid>,
/// The Face and Edge Ids of the cloned entity.
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub face_edge_ids: Vec<FaceEdgeInfo>,
Expand All @@ -807,9 +804,6 @@ define_ok_modeling_cmd_response_enum! {
/// The response from the `EntityLinearPatternTransform` command.
#[derive(Debug, Serialize, Deserialize, Clone, JsonSchema, ModelingCmdOutput)]
pub struct EntityLinearPatternTransform {
/// The UUIDs of the entities that were created.
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub entity_ids: Vec<Uuid>,
/// The Face, edge, and entity ids of the patterned entities.
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub entity_face_edge_ids: Vec<FaceEdgeInfo>,
Expand All @@ -818,9 +812,6 @@ define_ok_modeling_cmd_response_enum! {
/// The response from the `EntityLinearPattern` command.
#[derive(Debug, Serialize, Deserialize, Clone, JsonSchema, ModelingCmdOutput)]
pub struct EntityLinearPattern {
/// The UUIDs of the entities that were created.
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub entity_ids: Vec<Uuid>,
/// The Face, edge, and entity ids of the patterned entities.
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub entity_face_edge_ids: Vec<FaceEdgeInfo>,
Expand All @@ -829,9 +820,6 @@ define_ok_modeling_cmd_response_enum! {
/// The response from the `EntityCircularPattern` command.
#[derive(Debug, Serialize, Deserialize, Clone, JsonSchema, ModelingCmdOutput)]
pub struct EntityCircularPattern {
/// The UUIDs of the entities that were created.
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub entity_ids: Vec<Uuid>,
/// The Face, edge, and entity ids of the patterned entities.
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub entity_face_edge_ids: Vec<FaceEdgeInfo>,
Expand All @@ -840,9 +828,6 @@ define_ok_modeling_cmd_response_enum! {
/// The response from the `EntityMirror` endpoint.
#[derive(Debug, Serialize, Deserialize, Clone, JsonSchema, ModelingCmdOutput)]
pub struct EntityMirror {
/// The UUIDs of the entities that were created.
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub entity_ids: Vec<Uuid>,
/// The Face, edge, and entity ids of the patterned entities.
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub entity_face_edge_ids: Vec<FaceEdgeInfo>,
Expand All @@ -851,9 +836,6 @@ define_ok_modeling_cmd_response_enum! {
/// The response from the `EntityMirrorAcrossEdge` endpoint.
#[derive(Debug, Serialize, Deserialize, Clone, JsonSchema, ModelingCmdOutput)]
pub struct EntityMirrorAcrossEdge {
/// The UUIDs of the entities that were created.
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub entity_ids: Vec<Uuid>,
/// The Face, edge, and entity ids of the patterned entities.
#[serde(default, skip_serializing_if = "Vec::is_empty")]
pub entity_face_edge_ids: Vec<FaceEdgeInfo>,
Expand Down
Loading