Add Checksum Validation #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

gandy92 wants to merge 14 commits into KinDR007:main from gandy92:feature_checksum

Contributor

gandy92 commented Aug 21, 2025 •

edited

Loading

See #211 and #59

syssi reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

syssi reviewed

View reviewed changes

components/victron/victron.cpp Outdated Show resolved Hide resolved

syssi reviewed

View reviewed changes

components/victron/victron.cpp Outdated Show resolved Hide resolved

syssi reviewed

View reviewed changes

components/victron/victron.cpp Outdated Show resolved Hide resolved

syssi reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

gandy92 force-pushed the feature_checksum branch 2 times, most recently from 1ce8759 to e4b24d0 Compare

August 21, 2025 12:04

gandy92 added 4 commits

August 21, 2025 14:06


          Implement checksum validation controlled by boolean option validate_c…

f70bc8a

…hecksum


          Fix option to enable checksum validation

bb63355


          Improve checksum error warning

4b60482


          Switch buffer implementation from vector to string, add size contraint

3a5e718

gandy92 force-pushed the feature_checksum branch 3 times, most recently from 05aa2b6 to 90161f3 Compare

August 21, 2025 12:07

gandy92 and others added 9 commits

August 21, 2025 15:00


          Switch buffer implementation from vector to string, add size contraint

38792cf


          Add sanity checks when splitting block buffer

bef7a05


          Cleanup code, add more length checks

b1a64d6


          Make checksum validation the default

9948b8e


          Add note on checksum validation parameter

67824f3


          Update components/victron/victron.cpp

f9d2bf0

Co-authored-by: Sebastian Muszynski <basti@linkt.de>


          Choose proper name for frame buffer

6d40802


          Reset checksum after receiving a hex frame

4132c43


          Apply linter

db768eb

gandy92 force-pushed the feature_checksum branch from 122c3d9 to db768eb Compare

August 21, 2025 13:05

gandy92 commented

View reviewed changes

Contributor Author

gandy92 left a comment

Just realized I missed activating pre-commit hooks, now the linter ist happy.


          Satisfy clang-tidy for ESP32

0eea115

gandy92 requested a review from syssi

August 21, 2025 15:01

Collaborator

syssi commented Aug 22, 2025

I will do another review and some local testing next days. I will get back to you soon!

gandy92 mentioned this pull request

Checksum Validation #211

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet