Fix Scratch Buffer and SBT alignment violations in RT samples #1417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues:
VkPhysicalDeviceAccelerationStructureProperties::minAccelerationStructureScratchOffsetAlignment
. This can cause crashes if the default alignment reported byvkGetBufferMemoryRequirements
does not matchminAccelerationStructureScratchOffsetAlignment
.shaderGroupBaseAlignment
.This PR adds a way to specify the required alignment for a buffer. Internally, it updates the buffer creation code to use
vmaCreateBufferWithAlignment
instead ofvmaCreateBuffer
if an alignment is specified. I only updated theBufferBuilder
to allow a way to specify an alignment since the comments says the other Buffer constructor is now deprecated.The following samples have been updated to be alignment aware for scratch buffers and Shader
Testing
I did a full batch run on an AMD Radeon RX 9070XT and a Nvidia Geforce RTX 5090 on Windows. I currently don't have a setup to test other platforms.
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batch
command line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: