Skip to content

Don't reopen redirected standard handles on Windows #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Don't reopen redirected standard handles on Windows #1396

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71f41bb
Don't reopen redirected standard handles
AnyOldName3 Aug 15, 2025
18ae1ff
Run pre-commit scripts
AnyOldName3 Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions components/windows/src/context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/* Copyright (c) 2023, Thomas Atkinson
/* Copyright (c) 2023-2025, Thomas Atkinson
* Copyright (c) 2025, Chris Djali
*
* SPDX-License-Identifier: Apache-2.0
*
Expand Down Expand Up @@ -87,6 +88,15 @@ WindowsPlatformContext::WindowsPlatformContext(HINSTANCE hInstance, HINSTANCE hP
_temp_directory = get_temp_path_from_environment();
_arguments = get_args();

auto isRedirected = [](DWORD stdHandle) {
DWORD fileType = GetFileType(GetStdHandle(stdHandle));
return fileType == FILE_TYPE_DISK || fileType == FILE_TYPE_PIPE;
};

bool inRedirected = isRedirected(STD_INPUT_HANDLE);
bool outRedirected = isRedirected(STD_OUTPUT_HANDLE);
bool errRedirected = isRedirected(STD_ERROR_HANDLE);

// Attempt to attach to the parent process console if it exists
if (!AttachConsole(ATTACH_PARENT_PROCESS))
{
Expand All @@ -98,8 +108,17 @@ WindowsPlatformContext::WindowsPlatformContext(HINSTANCE hInstance, HINSTANCE hP
}

FILE *fp;
freopen_s(&fp, "conin$", "r", stdin);
freopen_s(&fp, "conout$", "w", stdout);
freopen_s(&fp, "conout$", "w", stderr);
if (!inRedirected)
{
freopen_s(&fp, "conin$", "r", stdin);
}
if (!outRedirected)
{
freopen_s(&fp, "conout$", "w", stdout);
}
if (!errRedirected)
{
freopen_s(&fp, "conout$", "w", stderr);
}
}
} // namespace vkb
Loading