Fix synchronization in Subpasses sample

[JoseEmilio-ARM]

Description

Achieve clean synchronization validation (Vulkan SDK 1.4.304.1) for the Subpasses sample

• When issuing a barrier, save the final image layout to be used consistently in other calls.
• Add correct subpass dependencies to avoid READ_AFTER_WRITE and WRITE_AFTER_WRITE hazards.
• Set correct layouts at render pass creation.
• Fix barriers in Subpasses sample.

Fixes #1197
Fixes #455
(maybe #867, #920)

General Checklist:

Please ensure the following points are checked:

• My code follows the coding style
• I have reviewed file licenses
• I have commented any added functions (in line with Doxygen)
• I have commented any code that could be hard to understand
• My changes do not add any new compiler warnings
• My changes do not add any new validation layer errors or warnings
• I have used existing framework/helper functions where possible
• My changes do not add any regressions
• I have tested every sample to ensure everything runs correctly
• This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

• I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
• My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

• I did a full batch run using the batch command line argument to make sure all samples still work properly

[asuessenbach]

Great fix!
Just a couple of minor issues.

[SaschaWillems]

Can confirm that this also fixes #920 for me 👍🏻

[marty-johnson59]

3 approvals - merging