Skip to content

Conversation

SaschaWillems
Copy link
Collaborator

Description

This PR updates the assets submodule to the latest commit, which contains the assets required for the recently merged dynamic rendering local read sample. No code changes.

Fixes #1163

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Contains assets for recently merged dynamic rendering local read sample
@SaschaWillems SaschaWillems added the urgent Need to resolve as soon as possible label Sep 13, 2024
@SaschaWillems
Copy link
Collaborator Author

Merging this as it's urgent. Without this, the dynamic rendering local read sample can't run.

@SaschaWillems SaschaWillems merged commit 16cd61e into KhronosGroup:main Sep 13, 2024
23 checks passed
@SaschaWillems SaschaWillems deleted the update_assets branch December 18, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

urgent Need to resolve as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assets for dynamic_rendering_local_read sample not available

2 participants