Skip to content

Conversation

SRSaunders
Copy link
Contributor

Description

This PR adds feature checks to the following samples prior to Vulkan device creation:

  1. dynamic_line_rasterization : rectangularLines, bresenhamLines, and smoothLines features
  2. extended_dynamic_state2: extendedDynamicState2 and extendedDynamicState2PatchControlPoints features
  3. logic_op_dynamic_state: extendedDynamicState2 and extendedDynamicState2LogicOp features
  4. patch_control_points: extendedDynamicState2 and extendedDynamicState2PatchControlPoints features

In addition, for dynamic_line_rasterization, the sample now enables line types individually, and provides feedback to users regarding which types are supported.

Also, for extended_dynamic_state2, the VK_EXT_primitive_topology_list_restart extension has been made optional to allow the sample to mostly work on macOS.

Tested on Windows 10 and macOS Ventura using an AMD 6600XT GPU with lastest AMD drivers and SDK 1.3.290. The samples no longer crash on Windows 10 when using AMD drivers, and run as per the following:

Windows 10: dynamic_line_rasterization runs with partial lines support; extended_dynamic_state2, logic_op_dynamic_state, and patch_control_points do not run based on lack of feature support, but exit cleanly.

macOS Ventura: extended_dynamic_state2 and patch_control_points run; dynamic_line_rasterization and logic_op_dynamic_state do not run based on lack of feature support, but exit cleanly.

Fixes #1144

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

@SaschaWillems
Copy link
Collaborator

I think this is already being addressed with #1013

@SRSaunders
Copy link
Contributor Author

Thanks @SaschaWillems - I was not aware of that work. I applied PR #1013 and it addresses issue #1144.

I will add a few comments on that thread and close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing feature checks cause sample crashes on Windows 10 + AMD GPU

2 participants