Skip to content

Conversation

Wang-JingWen
Copy link

@Wang-JingWen Wang-JingWen commented Oct 15, 2025

The changes include:

  • Add desktop OpenGL support.

    • Rebased the section numbers and page numbers against GL 4.6 core.
    • Moved the section [[If OVR_Multiview is supported]] from GL 4.6 main context to section Interactions with OVR_multiview.
    • ES 3.2 has no multiple viewport support, whereas GL 4.6 supports. Hence, added a new token FRAGMENT_SHADING_RATE_PRIMITIVE_RATE_WITH_MULTI_VIEWPORT_SUPPORTED_EXT and multiple viewport references to Section 14.X.2.
  • Refine some ambiguous or verbose descriptions.

    • Refined the definition for <texelWidth> and <texelHeight> in Section 14.X.3.
    • Clarified the defination of _effective shading rate_ in Section 14.X.4.
    • Refined the definition for <combinerOp0> and <combinerOp1> in Section 14.X.4.
    • The paragraph "If the final combined rate is one of the rates ......" in Section 14.X.4 is imprecise, made it adheres to VK_KHR_fragment_shading_rate specification.
  • Polish the extension formatting.

    • Removed the unexpected indent (the first 4 blank spaces) for the whole file.
    • Limited the lines to 80 characters wide (not exactly, tables excepted).
    • The number of preceding spaces for each sentence was inconsistent(1 space and 2 spaces mixed). Uniformed the format to 1 space preceding.
    • Moved sections Interactions with * prior to Errors, which is more in line with norms.

Copy link
Contributor

@janharaldfredriksen-arm janharaldfredriksen-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me.

specified a fragment shading rate value of 0, indicating a horizontal and
vertical rate of 1 pixel.

FRAGMENT_SHADING_RATE_PRIMITIVE_RATE_WITH_MULTI_VIEWPORT_SUPPORTED_EXT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need some statement somewhere to say that this is not available when implemented against GLES.
Maybe something like:

Dependencies on OpenGL 4.6

If OpenGL 4.6 is not supported, references to the FRAGMENT_SHADING_RATE_PRIMITIVE_RATE_WITH_MULTI_VIEWPORT_SUPPORTED_EXT should
be removed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice hint! Added in section Interactions with OpenGL ES 3.2

Interactions with OpenGL ES 3.2

    If implemented in OpenGL ES, references to multiple viewports and
    FRAGMENT_SHADING_RATE_PRIMITIVE_RATE_WITH_MULTI_VIEWPORT_SUPPORTED_EXT
    should be removed.

@Wang-JingWen Wang-JingWen force-pushed the fragment_shading_rate branch from 62a8f27 to 00f38cd Compare October 16, 2025 03:43
@Wang-JingWen Wang-JingWen force-pushed the fragment_shading_rate branch from 00f38cd to 47909da Compare October 16, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants