Skip to content

Conversation

zmike
Copy link
Contributor

@zmike zmike commented Apr 23, 2025

Internal issue 247.

@zmike zmike added this to the Approved to Merge milestone May 7, 2025
@zmike
Copy link
Contributor Author

zmike commented May 7, 2025

@oddhack please merge

Still awaiting discussion.

Comment on lines +1006 to +1007
but these functionalities are not supported in OpenGL ES and will return
null pointers.
Copy link

@fooishbar fooishbar May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right. GPA is defined to be independent of the currently-bound API; it can (necessarily) be used before any client API is bound, and it's defined to return a pointer which can be used on a client API on that implementation, regardless of what's currently bound.

So specifying that eglGetProcAddress("glTextureStorage2DEXT") breaks implementations which expose both GL+DSA and GLES+TS, because they need to return the GL pointer for this query at all times. You can weaken the language to 'may', but honestly you could just delete anything referring to GPA and just note that the function prototypes were erroneously included, are not defined to have any functionality in GLES, and should not be used.

The core GPA definition is very clear that just because it returns a function pointer, doesn't mean you can use it anywhere.

@fooishbar
Copy link

@oddhack please merge

@oddhack please don't, at least not yet :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants