Added support for cl_ext_float_atomics in CBasicTestFetchMinSpecialFloats with atomic_float #2391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oats with atomic_float
shajder
commented
May 15, 2025
Comment on lines
+2293
to
+2297
| else if (is_qnan(StartValue())) | ||
| return testValue[whichDestValue] | ||
| != startRefValues[whichDestValue]; | ||
| else | ||
| return testValue[whichDestValue] != StartValue(); |
There was a problem hiding this comment.
@bashbaug at this point my test fails with intel driver. As per spec:
min(x, qNaN) = min(qNaN, x) = x,
I am observing incorrect behaviour with qNaN and -0.f arguments which returns NaN instead -0.f. Please let me know if I am missing something, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2142, according to the work plan, extending CBasicTestFetchMinSpecialFloats with support for atomic_float.